Skip to content

Conversation

@ipanfilo
Copy link
Collaborator

@ipanfilo ipanfilo commented Feb 3, 2026

Description

Use wheel package names for ROCm TE that are uniq and do not match CUDA TE ones.

Fixes #15360

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refactoring

Changes

Please list the changes introduced in this PR:

  • Rename transformer_engine_(torch|jax) to transformer_engine_rocm_(torch|jax)
  • Make transformer_engine_rocm independent, i.e it can install and work w/o transformer_engine metapackage
  • Add configuration parameters to build_wheels.sh

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@wenchenvincent
Copy link
Collaborator

If we use an AMD pypi repo to host the wheels, do we still need the package name changes?

@ipanfilo
Copy link
Collaborator Author

ipanfilo commented Feb 4, 2026

If we use an AMD pypi repo to host the wheels, do we still need the package name changes?
Yes, unless we disable using default PyPi index at all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants