[bsp] add n32 pwm driver by chejia12 · Pull Request #11236 · RT-Thread/rt-thread

chejia12 · 2026-03-05T03:08:44Z

拉取/合并请求描述：(PR description)

[

add bsp driver

1.add n32xxx pwm driver

Test

N32
Test OK on 2 dev boards; KConfig modified for all official dev boards:
bsp\32\32l40xcl-stb: Tested OK
bsp\32\32g457qel-stb: Tested OK
Other boards: KConfig updated, compiled without errors/warnings (no physical board test yet)

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality：

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

已经仔细查看过代码改动的对比 Already check the difference between PR and old code
代码风格正确，包括缩进空格，命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
没有垃圾代码，代码尽量精简，不包含#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up
所有变更均有原因及合理的，并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
代码是高质量的 Code in this PR is of high quality
已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
如果是新增bsp, 已经添加ci检查到.github/ALL_BSP_COMPILE.json 详细请参考链接BSP自查

github-actions · 2026-03-05T03:08:52Z

👋 感谢您对 RT-Thread 的贡献！Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范，请在你的仓库中执行以下步骤运行代码格式化工作流（如果格式化CI运行失败）。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).

🛠 操作步骤 | Steps

前往 Actions 页面 | Go to the Actions page
点击进入工作流 → | Click to open workflow →
点击 Run workflow | Click Run workflow

设置需排除的文件/目录（目录请以"/"结尾）
Set files/directories to exclude (directories should end with "/")
将目标分支设置为 \ Set the target branch to：master
设置PR number为 \ Set the PR number to：11236

等待工作流完成 | Wait for the workflow to complete
格式化后的代码将自动推送至你的分支。
The formatted code will be automatically pushed to your branch.

完成后，提交将自动更新至 master 分支，关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the master branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们，再次感谢您的贡献！💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

Rbb666 · 2026-03-06T01:48:37Z

bsp/n32/n32gxx_lxx/libraries/n32_drivers/drv_pwm.c

+ * Change Logs:
+ * Date           Author       						Notes
+ * 2025-12-02     Car12(1085582540@qq.com)       	first version
+


删除多余的换行

Rbb666 · 2026-03-06T01:49:04Z

bsp/n32/n32gxx_lxx/libraries/n32_drivers/drv_pwm.c

+ * Change Logs:
+ * Date           Author       						Notes
+ * 2025-12-02     Car12(1085582540@qq.com)       	first version
+


请删除文件中多余的换行

Copilot

Pull request overview

This PR introduces a PWM driver for N32 BSPs and wires it into multiple N32 board Kconfigs and build scripts so PWM can be enabled per-board/per-timer.

Changes:

Add drv_pwm.c implementing RT-Thread PWM device ops for N32 timers/channels.
Add PWM-related Kconfig options to multiple N32 board BSPs (TIM1/2/3 + pin/remap/channel selection).
Update SConscripts to compile the new PWM driver and ensure timer peripheral sources are included when PWM is enabled.

Reviewed changes

Copilot reviewed 20 out of 20 changed files in this pull request and generated 23 comments.

Show a summary per file

File	Description
bsp/n32/n32gxx_lxx/n32wb45xl-evb/board/Kconfig	Adds PWM Kconfig options (TIM1/2/3, remap, channels) for this board
bsp/n32/n32gxx_lxx/n32l43xrl-stb/board/Kconfig	Adds PWM Kconfig options (TIM1/2/3, per-channel pin choices)
bsp/n32/n32gxx_lxx/n32l43xml-stb/board/Kconfig	Adds PWM Kconfig options (TIM1/2/3, per-channel pin choices)
bsp/n32/n32gxx_lxx/n32l436-evb/board/Kconfig	Adds PWM Kconfig options (TIM1/2/3, per-channel pin choices)
bsp/n32/n32gxx_lxx/n32l40xcl-stb/board/Kconfig	Adds PWM Kconfig options (TIM1/2/3, per-channel pin choices)
bsp/n32/n32gxx_lxx/n32g4frml-stb/board/Kconfig	Adds PWM Kconfig options (TIM1/2/3, remap, channels)
bsp/n32/n32gxx_lxx/n32g45xvl-stb/board/Kconfig	Adds PWM Kconfig options (TIM1/2/3, remap, channels)
bsp/n32/n32gxx_lxx/n32g45xrl-stb/board/Kconfig	Adds PWM Kconfig options (TIM1/2/3, remap, channels)
bsp/n32/n32gxx_lxx/n32g45xml-stb/board/Kconfig	Adds PWM Kconfig options (TIM1 remap/channels)
bsp/n32/n32gxx_lxx/n32g45xcl-stb/board/Kconfig	Adds PWM Kconfig options (TIM1/2/3, remap, channels)
bsp/n32/n32gxx_lxx/n32g457qel-stb/board/Kconfig	Adds PWM Kconfig options (TIM1/2/3, remap, channels)
bsp/n32/n32gxx_lxx/n32g43xcl-stb/board/Kconfig	Adds PWM Kconfig options (TIM1/2/3, remap, channels)
bsp/n32/n32gxx_lxx/libraries/n32_drivers/drv_pwm.c	New N32 PWM driver implementation and device registration
bsp/n32/n32gxx_lxx/libraries/n32_drivers/SConscript	Builds `drv_pwm.c` when `BSP_USING_PWM` is enabled
bsp/n32/n32gxx_lxx/libraries/N32WB452_Firmware_Library/SConscript	Adds timer peripheral source when PWM is enabled
bsp/n32/n32gxx_lxx/libraries/N32L43x_Firmware_Library/SConscript	Adds timer peripheral source when PWM is enabled
bsp/n32/n32gxx_lxx/libraries/N32L40x_Firmware_Library/SConscript	Adds timer peripheral source when PWM is enabled
bsp/n32/n32gxx_lxx/libraries/N32G4FR_Firmware_Library/SConscript	Adds timer peripheral source when PWM is enabled
bsp/n32/n32gxx_lxx/libraries/N32G45x_Firmware_Library/SConscript	Adds timer peripheral source when PWM is enabled
bsp/n32/n32gxx_lxx/libraries/N32G43x_Firmware_Library/SConscript	Adds timer peripheral source when PWM is enabled

Copilot · 2026-03-06T01:55:48Z

bsp/n32/n32gxx_lxx/n32l43xrl-stb/board/Kconfig

+                        endchoice
+                    endif
+                config BSP_USING_TIM2_PWM_CH4
+                    bool "Enable TIM2 channel3 AF2 PB11"


[documentation/文档]: TIM2 CH4 prompt text references the wrong channel

English: config BSP_USING_TIM2_PWM_CH4 is described as "Enable TIM2 channel3 AF2 PB11". This is misleading (channel number doesn't match CH4). Please fix the prompt string so it correctly reflects CH4 and its pin/AF.
中文：config BSP_USING_TIM2_PWM_CH4 的提示文本是“Enable TIM2 channel3 AF2 PB11”，与 CH4 不一致，容易误导。建议修正提示字符串，使其正确描述 CH4 对应的通道/引脚/复用。

Suggested change

bool "Enable TIM2 channel3 AF2 PB11"

bool "Enable TIM2 channel4 AF2 PB11"

Copilot · 2026-03-06T01:55:49Z

bsp/n32/n32gxx_lxx/n32l43xml-stb/board/Kconfig

+                        endchoice
+                    endif
+                config BSP_USING_TIM2_PWM_CH4
+                    bool "Enable TIM2 channel3 AF2 PB11"


[documentation/文档]: TIM2 CH4 prompt text references the wrong channel

English: config BSP_USING_TIM2_PWM_CH4 is described as "Enable TIM2 channel3 AF2 PB11". This is misleading for CH4. Please fix the prompt string so it correctly reflects CH4 and its pin/AF.
中文：config BSP_USING_TIM2_PWM_CH4 的提示文本写成了“Enable TIM2 channel3 AF2 PB11”，与 CH4 不一致，容易误导。建议修正提示字符串，使其正确描述 CH4 对应的通道/引脚/复用。

Suggested change

bool "Enable TIM2 channel3 AF2 PB11"

bool "Enable TIM2 channel4 AF2 PB11"

Copilot · 2026-03-06T01:55:49Z

bsp/n32/n32gxx_lxx/n32l436-evb/board/Kconfig

+                        endchoice
+                    endif
+                config BSP_USING_TIM2_PWM_CH4
+                    bool "Enable TIM2 channel3 AF2 PB11"


[documentation/文档]: TIM2 CH4 prompt text references the wrong channel

English: config BSP_USING_TIM2_PWM_CH4 is described as "Enable TIM2 channel3 AF2 PB11". This is misleading for CH4. Please fix the prompt string so it correctly reflects CH4 and its pin/AF.
中文：config BSP_USING_TIM2_PWM_CH4 的提示文本写成了“Enable TIM2 channel3 AF2 PB11”，与 CH4 不一致，容易误导。建议修正提示字符串，使其正确描述 CH4 对应的通道/引脚/复用。

Suggested change

bool "Enable TIM2 channel3 AF2 PB11"

bool "Enable TIM2 channel4 PB11 AF2"

Copilot · 2026-03-06T01:55:49Z

bsp/n32/n32gxx_lxx/libraries/n32_drivers/drv_pwm.c

+    tim_clock = tim_clock_get(tim);
+
+    tim_clock /= 1000000UL;
+    /*caculate  period*/ 
+    period = (TIM_GetAutoReload(tim) + 1) * (TIM_GetPrescaler(tim) + 1) * 1000UL / tim_clock;
+    pulse = (rt_uint64_t)configuration->pulse * (TIM_GetAutoReload(tim) + 1) / period;
+
+    if (pulse < MIN_PULSE)
+    {
+        pulse = MIN_PULSE;
+    }
+    /*To determine user input, output high level is required*/
+    else if (pulse >= period)
+    {
+        pulse = period + 1;


[bug/缺陷]: Unit mismatch in drv_pwm_set_pulse makes 100% duty handling wrong

English: period is computed in nanoseconds, but pulse is computed in timer ticks. The comparison pulse >= period (and then pulse = period + 1) mixes units, so the clamp logic is incorrect and can set an out-of-range compare value. Use consistent units (e.g., compare configuration->pulse >= configuration->period, or compare pulse >= (ARR+1) in ticks).
中文：period 计算结果是纳秒(ns)，而 pulse 计算结果是计数器 tick。pulse >= period（以及 pulse = period + 1）混用了单位，导致占空比边界判断/钳位逻辑错误，并可能写入越界的比较值。需要统一单位（例如比较 configuration->pulse >= configuration->period，或在 tick 单位下比较 pulse >= (ARR+1)）。

Suggested change

tim_clock = tim_clock_get(tim);

tim_clock /= 1000000UL;

/*caculate period*/

period = (TIM_GetAutoReload(tim) + 1) * (TIM_GetPrescaler(tim) + 1) * 1000UL / tim_clock;

pulse = (rt_uint64_t)configuration->pulse * (TIM_GetAutoReload(tim) + 1) / period;

if (pulse < MIN_PULSE)

{

pulse = MIN_PULSE;

}

/*To determine user input, output high level is required*/

else if (pulse >= period)

{

pulse = period + 1;

rt_uint32_t auto_reload = TIM_GetAutoReload(tim) + 1;

tim_clock = tim_clock_get(tim);

tim_clock /= 1000000UL;

/*caculate period*/

period = auto_reload * (TIM_GetPrescaler(tim) + 1) * 1000UL / tim_clock;

pulse = (rt_uint64_t)configuration->pulse * auto_reload / period;

/* To determine user input, output high level is required */

if (configuration->pulse >= period)

{

/* 100% or above duty: keep output high over the whole period */

pulse = auto_reload;

}

else if (pulse < MIN_PULSE)

{

pulse = MIN_PULSE;

Copilot · 2026-03-06T01:55:49Z

bsp/n32/n32gxx_lxx/n32wb45xl-evb/board/Kconfig

+        menuconfig BSP_USING_TIM1_PWM
+            bool "Enable TIM1 output PWM"
+            default n
+            # --------------selcet remap-----------------


[spelling/拼写]: Typo in comment selcet

English: The comment says selcet remap; please correct to select remap.
中文：注释中 selcet remap 存在拼写错误，建议更正为 select remap。

Suggested change

# --------------selcet remap-----------------

# --------------select remap-----------------

Copilot · 2026-03-06T01:55:52Z

bsp/n32/n32gxx_lxx/libraries/n32_drivers/drv_pwm.c

+            // .tim = TIM2,
+            // .name = "pwm2",


[bug/缺陷]: TIM2 PWM object is missing required fields

English: In the #ifdef BSP_USING_TIM2_PWM initializer, .tim = TIM2 and .name = "pwm2" are commented out. This leaves device->tim as NULL/0 for that entry, causing n32_time_rcc_config(device->tim) to assert/fail and breaking PWM registration/initialization when TIM2 PWM is enabled.
中文：在 #ifdef BSP_USING_TIM2_PWM 的对象初始化中，.tim = TIM2 和 .name = "pwm2" 被注释掉了，导致该对象的 device->tim 为空/0。启用 TIM2 PWM 时会在 n32_time_rcc_config(device->tim) 处断言失败，PWM 初始化/注册会直接出错。

Suggested change

// .tim = TIM2,

// .name = "pwm2",

.tim = TIM2,

.name = "pwm2",

Copilot · 2026-03-06T01:55:53Z

bsp/n32/n32gxx_lxx/libraries/n32_drivers/drv_pwm.c

+    if ((GPIOA == gpio_grp && GPIO_PIN_15) ||
+        (GPIOB == gpio_grp && GPIO_PIN_3) ||
+        (GPIOB == gpio_grp && GPIO_PIN_4))


[bug/缺陷]: JTAG/SWD remap condition ignores pin and always triggers for GPIOA/GPIOB

English: The condition uses (GPIOA == gpio_grp && GPIO_PIN_15) etc. Since GPIO_PIN_15/3/4 are non-zero constants, the && expression does not check the pin argument at all. This will remap JTAG->SWD whenever gpio_grp matches, potentially disabling JTAG unexpectedly. Compare against the pin parameter (e.g., pin == GPIO_PIN_15 or pin & GPIO_PIN_15).
中文：条件写成了 (GPIOA == gpio_grp && GPIO_PIN_15) 等，由于 GPIO_PIN_15/3/4 是非零常量，该判断并没有使用 pin 参数，导致只要 gpio_grp 匹配就会执行 JTAG->SWD 重映射，可能意外关闭 JTAG。应当用 pin 参数进行比较（如 pin == GPIO_PIN_15 或 pin & GPIO_PIN_15）。

Suggested change

if ((GPIOA == gpio_grp && GPIO_PIN_15) ||

(GPIOB == gpio_grp && GPIO_PIN_3) ||

(GPIOB == gpio_grp && GPIO_PIN_4))

if ((GPIOA == gpio_grp && (pin & GPIO_PIN_15)) ||

(GPIOB == gpio_grp && (pin & GPIO_PIN_3)) ||

(GPIOB == gpio_grp && (pin & GPIO_PIN_4)))

Copilot · 2026-03-06T01:55:53Z

bsp/n32/n32gxx_lxx/libraries/n32_drivers/drv_pwm.c

+    uint16_t tim_ch;
+    switch (channel)
+    {
+    case 0:
+        tim_ch = TIM_CH_1;
+        break;
+    case 1:
+        tim_ch = TIM_CH_2;
+        break;
+    case 2:
+        tim_ch = TIM_CH_3;
+        break;
+    case 3:
+        tim_ch = TIM_CH_4;
+
+    default:
+        break;
+    }
+
+    TIM_EnableCapCmpCh(time, tim_ch, enable ? TIM_CAP_CMP_ENABLE : TIM_CAP_CMP_DISABLE);
+


[bug/缺陷]: Invalid channel values can use an uninitialized tim_ch

English: If channel is not 0..3, the switch falls into default without assigning tim_ch, but TIM_EnableCapCmpCh() is still called. Return -RT_EINVAL (or assert) on invalid channels to avoid unpredictable behavior.
中文：当 channel 不在 0..3 时，switch 进入 default 且没有给 tim_ch 赋值，但仍然调用了 TIM_EnableCapCmpCh()，会导致不可预期行为。建议对非法 channel 直接返回 -RT_EINVAL（或断言）。

Copilot · 2026-03-06T01:55:53Z

bsp/n32/n32gxx_lxx/libraries/N32WB452_Firmware_Library/SConscript

 if GetDepend(['RT_USING_CLOCK_TIME']):
    src += ['n32wb452_std_periph_driver/src/n32wb452_tim.c']

+if GetDepend(['RT_USING_PWM']):
+    src += ['n32wb452_std_periph_driver/src/n32wb452_tim.c']
+


[bug/缺陷]: Duplicate source inclusion of n32wb452_tim.c

English: n32wb452_tim.c is added under both RT_USING_CLOCK_TIME and RT_USING_PWM. If both are enabled, the same C file will be compiled twice, typically causing duplicate object/duplicate symbol build failures. Add the file only once (e.g., gate it behind a combined condition or de-duplicate the src list).
中文：n32wb452_tim.c 同时在 RT_USING_CLOCK_TIME 和 RT_USING_PWM 条件下被加入 src。如果两者同时使能，同一源文件会被编译两次，通常会导致重复目标文件/重复符号的构建失败。应保证该文件只被加入一次（例如使用合并条件或对 src 去重）。

Copilot · 2026-03-06T01:55:53Z

bsp/n32/n32gxx_lxx/libraries/N32G43x_Firmware_Library/SConscript

 if GetDepend(['RT_USING_CLOCK_TIME']):
    src += ['n32g43x_std_periph_driver/src/n32g43x_tim.c']
+
+if GetDepend(['RT_USING_PWM']):
+    src += ['n32g43x_std_periph_driver/src/n32g43x_tim.c']



[bug/缺陷]: Duplicate source inclusion of n32g43x_tim.c

English: n32g43x_tim.c is appended in both the RT_USING_CLOCK_TIME and RT_USING_PWM conditions. When both are enabled, the same source may be compiled twice and break the build with duplicate symbols. Ensure it is included only once.
中文：n32g43x_tim.c 同时在 RT_USING_CLOCK_TIME 与 RT_USING_PWM 条件下加入；两者同时开启时可能导致重复编译并引发重复符号的构建失败。请确保只加入一次。

Suggested change

if GetDepend(['RT_USING_CLOCK_TIME']):

src += ['n32g43x_std_periph_driver/src/n32g43x_tim.c']

if GetDepend(['RT_USING_PWM']):

src += ['n32g43x_std_periph_driver/src/n32g43x_tim.c']

if GetDepend(['RT_USING_CLOCK_TIME']) or GetDepend(['RT_USING_PWM']):

src += ['n32g43x_std_periph_driver/src/n32g43x_tim.c']

[bsp] add n32 pwm driver

e8b375e

github-actions bot added the BSP label Mar 5, 2026

Rbb666 reviewed Mar 6, 2026

View reviewed changes

Rbb666 requested a review from Copilot March 6, 2026 01:49

Copilot started reviewing on behalf of Rbb666 March 6, 2026 01:50 View session

Copilot AI reviewed Mar 6, 2026

View reviewed changes

	bool "Enable TIM2 channel3 AF2 PB11"
	bool "Enable TIM2 channel4 AF2 PB11"

	bool "Enable TIM2 channel3 AF2 PB11"
	bool "Enable TIM2 channel4 PB11 AF2"

	# --------------selcet remap-----------------
	# --------------select remap-----------------

Conversation

chejia12 commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

拉取/合并请求描述：(PR description)

add bsp driver

Test

当前拉取/合并请求的状态 Intent for your PR

代码质量 Code Quality：

Uh oh!

github-actions bot commented Mar 5, 2026

🛠 操作步骤 | Steps

Uh oh!

Rbb666 Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

Rbb666 Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

chejia12 commented Mar 5, 2026 •

edited

Loading