Skip to content

fix: Clamp transforms to sensible levels of precision - #10268

Open
gonfunko wants to merge 1 commit into
mainfrom
rounders
Open

fix: Clamp transforms to sensible levels of precision#10268
gonfunko wants to merge 1 commit into
mainfrom
rounders

Conversation

@gonfunko

Copy link
Copy Markdown
Contributor

The basics

The details

Proposed Changes

This PR clamps text width and workspace translation to integer values, and workspace scale to 3 decimals. Previously these were unbounded, typically leading to 14 digits of decimal precision, which is obviously unnecessary, and more computationally intensive.

Test Coverage

All tests pass, and I visually inspected the blocks and zooming.

@gonfunko
gonfunko requested a review from a team as a code owner August 12, 2026 19:51
@gonfunko
gonfunko requested a review from mikeharv August 12, 2026 19:51
@github-actions github-actions Bot added the PR: fix Fixes a bug label Aug 12, 2026

@mikeharv mikeharv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be worth calling out that this could potentially result in tiny visual differences, especially for applications that rely upon reference images for automated regression testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: fix Fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants