Repository navigation
fix: restore passive focus on full-block fields in Zelos - #10559
Open
minwookshin wants to merge 4 commits into
Open
minwookshin wants to merge 4 commits into
minwookshin wants to merge 4 commits into
Conversation
Contributor
There was a problem hiding this comment.
Welcome! It looks like this is your first pull request in Blockly, so here are a couple of tips:
- You can find tips about contributing to Blockly and how to validate your changes on our developer site.
- We use conventional commits to make versioning the package easier. Make sure your commit message is in the proper format or learn how to fix it.
- If any of the other checks on this PR fail, you can click on them to learn why. It might be that your change caused a test failure, or that you need to double-check the style guide.
Thank you for opening this PR! A member of the Blockly team will review it soon.
mikeharv
requested changes
Oct 5, 2026
Contributor
There was a problem hiding this comment.
Hi Minwook! Thanks for submitting this fix. The change itself works, but I'm requesting a couple small changes before we can merge this.
- Use
dom.addClassinstead ofthis.fieldGroup_.classList.add(...). The rest ofFielduses the helper already, including ininitView()a few lines below. - The AI generated tests are a little too padded for what this change is. I think we can cut the test down to a single full-block case. It would be good if we could do this without depending on the exact 5px 3px values.
Please re-tag me for review when you'd like me to take another look.
mikeharv
requested changes
Oct 5, 2026
mikeharv
left a comment
Contributor
There was a problem hiding this comment.
Thanks for making those changes. Instead of creating a brand new test file, could we add this new test to a new or existing suite in keyboard_navigation_test.ts?
Author
|
Moved the test to |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the missing passive focus outline on full-block fields in Zelos. Ran regression tests and reviewed the changes.
Fixes #10504.
AI assistance: OpenAI Codex (implementation and regression tests).