Skip to content

fix: keep the additional-properties catch-all on generated models - #195

Merged
robertmarsal merged 1 commit into
mainfrom
fix-additional-properties-catchall
Sep 21, 2026
Merged

robertmarsal merged 1 commit into
mainfrom
fix-additional-properties-catchall

Conversation

@robertmarsal

Copy link
Copy Markdown
Contributor
  • Normalise additionalProperties: false to true (or drop it on property-less schemas) in the OpenAPI spec before generating, in both CI and scripts/generate-local.sh — the generator reads the explicit false inconsistently, so the catch-all silently comes and goes between spec revisions
  • Generating from the normalised spec restores the catch-all on 305 further models (335 -> 640 of 678); the scratch openapi.json is removed in scripts/postprocess.sh so it is never committed

@robertmarsal
robertmarsal marked this pull request as ready for review September 21, 2026 19:51
@robertmarsal
robertmarsal requested a review from a team as a code owner September 21, 2026 19:51
@robertmarsal
robertmarsal merged commit 37d3875 into main Sep 21, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant