Skip to content

Reintroduce library_path.sh patches from humble to fix LD_LIBRARY_PATH pollution#7

Merged
Tobias-Fischer merged 2 commits into
RoboStack:mainfrom
Ryan4253:main
Jun 29, 2026
Merged

Reintroduce library_path.sh patches from humble to fix LD_LIBRARY_PATH pollution#7
Tobias-Fischer merged 2 commits into
RoboStack:mainfrom
Ryan4253:main

Conversation

@Ryan4253

Copy link
Copy Markdown
Contributor

Same patch ported from ros-jazzy

@Tobias-Fischer

Copy link
Copy Markdown
Contributor

Hi @Ryan4253 - many thanks! Do you know which packages need to be rebuilt for this to take effect?

@Ryan4253

Ryan4253 commented Jun 28, 2026

Copy link
Copy Markdown
Contributor Author

@Tobias-Fischer Any ament_cmake package that exports a shared library (via ament_export_libraries, transitively via ament_export_targets, rosidl, directly exporting a .so etc.) will need to be rebuilt.

I don't have a good way to filter out what packages should be rebuilt given the number of cases / transitive exporting that can happen. I think it would be easier to just do a full rebuild if possible.

@Tobias-Fischer

Copy link
Copy Markdown
Contributor

Do you want to give it a go to do a full rebuild? Shouldn’t be too bad given we very recently did one. I won’t have capacity to do one myself for at least a few weeks.

@Ryan4253

Ryan4253 commented Jun 28, 2026

Copy link
Copy Markdown
Contributor Author

@Tobias-Fischer Let me know how the latest commit looks. Should be ready for a full rebuild CI run

@Tobias-Fischer Tobias-Fischer merged commit 329feef into RoboStack:main Jun 29, 2026
2 of 5 checks passed
@Ryan4253

Copy link
Copy Markdown
Contributor Author

@Tobias-Fischer Thanks for all the help. It looks like
IGNORE_CACHE_AND_DO_FULL_REBUILD is still set to true you might want to make a commit to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants