fix(login): gracefully handle network drop crash during authentication#1211
Open
deepak0x wants to merge 1 commit intoRocketChat:developfrom
Open
fix(login): gracefully handle network drop crash during authentication#1211deepak0x wants to merge 1 commit intoRocketChat:developfrom
deepak0x wants to merge 1 commit intoRocketChat:developfrom
Conversation
deepak0x
force-pushed
the
fix/1210-login-network-error-crash
branch
from
99948a5 to
8704cc0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle undefined response in login hook
When a user attempts to log in but encounters a network error (e.g.
net::ERR_NETWORK_CHANGED), the fetch call inEmbeddedChatApi.loginthrows an error. The catch block logs the error but implicitly returnsundefined. Subsequently,useRCAuth.jsattempts to readres.error, leading to an uncaughtTypeError: Cannot read properties of undefined (reading 'error')which completely breaks the login flow.This adds a falsy check for the response object and dispatches a user-friendly toast message informing them of the network connection issue instead of crashing.
Fixes #1210