Merged
Conversation
✅ Deploy Preview for antenna-ssec ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for antenna-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
📝 WalkthroughWalkthroughForm layout styles simplified and Changes
Sequence Diagram(s)mermaid User->>Router: navigates to page with picker Estimated code review effort🎯 3 (Moderate) | ⏱️ ~22 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 3❌ Failed checks (1 warning, 2 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@ui/src/design-system/components/select/capture-set-picker.tsx`:
- Around line 25-40: CaptureSetPicker currently only renders concrete capture
set options so users cannot revert to “none”; add an optional empty selection by
introducing an allowEmpty boolean prop on CaptureSetPicker and when allowEmpty
is true render an extra Select.Item (e.g., value="" or a sentinel like "none")
at the top of Select.Content (with placeholder label like "No capture set" or
empty) so onValueChange can receive the empty value and callers can clear the
selection; update any optional consumers (export form) to pass allowEmpty and
handle the empty sentinel as the skip-capture-set case.
In `@ui/src/pages/job-details/job-details-form/job-details-form.tsx`:
- Around line 105-107: The FormMessage usage in job-details-form.tsx currently
embeds a hard-coded English string; replace it with the i18n key by using
translate(STRING.MESSAGE_BATCH_PROCESSING_WARNING) and add
STRING.MESSAGE_BATCH_PROCESSING_WARNING to ui/src/utils/language.ts (ensuring
the key maps to the existing English message and any other locales as needed).
Locate the FormMessage instance in job-details-form.tsx to swap out the literal
message and update the language.ts file to export the new STRING constant so
translate(...) can resolve it.
In `@ui/src/pages/project/capture-sets/capture-set-columns.tsx`:
- Around line 56-71: The current early return renders PopulateCaptureSet when
item.canPopulate && item.numImages === 0 even if item.currentJob exists, hiding
real job state; update the rendering order in capture-set-columns.tsx to check
item.currentJob first and render StatusTableCell (using
item.currentJob.status.color, item.currentJob.type.label,
item.currentJob.status.label) when present, otherwise fall back to the
PopulateCaptureSet branch (when item.canPopulate && item.numImages === 0) and
then the empty/default case—adjust the conditional logic around
PopulateCaptureSet and StatusTableCell so status is preferred whenever
item.currentJob is defined.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 6865684c-f68d-491e-8d44-a5291738fade
📒 Files selected for processing (16)
ui/src/components/form/layout/layout.module.scssui/src/components/form/layout/layout.tsxui/src/design-system/components/button/docs-link.tsxui/src/design-system/components/info-tooltip.tsxui/src/design-system/components/select/capture-set-picker.tsxui/src/pages/captures/capture-columns.tsxui/src/pages/deployment-details/deployment-details-info.tsxui/src/pages/deployments/deployment-columns.tsxui/src/pages/job-details/job-details-form/job-details-form.tsxui/src/pages/project/capture-sets/capture-set-columns.tsxui/src/pages/project/capture-sets/populate-capture-set.tsxui/src/pages/project/entities/details-form/capture-set-details-form.tsxui/src/pages/project/entities/details-form/export-details-form.tsxui/src/pages/session-details/session-info/session-info.tsxui/src/pages/sessions/session-columns.tsxui/src/utils/language.ts
💤 Files with no reviewable changes (1)
- ui/src/components/form/layout/layout.module.scss
Contributor
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
ui/src/pages/deployment-details/deployment-details-form/deployment-details-form.tsx (1)
49-63:⚠️ Potential issue | 🟠 MajorValidation regression: avoid hardcoding section validity to
trueLine 54 and Line 62 initialize
Section.LocationandSection.SourceImagesas valid unconditionally. This bypasses initial validity gating and can permit stepping/saving before those sections are actually validated.Suggested fix
[Section.Location]: { values: { latitude: deployment.latitude, longitude: deployment.longitude, }, - isValid: true, + isValid: startValid, }, [Section.SourceImages]: { values: { dataSourceId: deployment.dataSource?.id, dataSourceSubdir: deployment.dataSourceSubdir, dataSourceRegex: deployment.dataSourceRegex, }, - isValid: true, + isValid: startValid, },🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@ui/src/pages/deployment-details/deployment-details-form/deployment-details-form.tsx` around lines 49 - 63, The code currently forces Section.Location and Section.SourceImages to isValid: true which bypasses validation; update the initialization in deployment-details-form (the object keyed by Section.Location and Section.SourceImages) to compute isValid from the actual field values instead of hardcoding true — e.g., call the existing validation helper used elsewhere (or run the same checks used in validateSection/validateLocation/validateSourceImages) against latitude/longitude and dataSourceId/dataSourceSubdir/dataSourceRegex and set isValid to that boolean, or default to false if no validator is available; ensure you reference the same validation logic the form uses so stepping/saving respects real validity.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In
`@ui/src/pages/deployment-details/deployment-details-form/deployment-details-form.tsx`:
- Around line 49-63: The code currently forces Section.Location and
Section.SourceImages to isValid: true which bypasses validation; update the
initialization in deployment-details-form (the object keyed by Section.Location
and Section.SourceImages) to compute isValid from the actual field values
instead of hardcoding true — e.g., call the existing validation helper used
elsewhere (or run the same checks used in
validateSection/validateLocation/validateSourceImages) against
latitude/longitude and dataSourceId/dataSourceSubdir/dataSourceRegex and set
isValid to that boolean, or default to false if no validator is available;
ensure you reference the same validation logic the form uses so stepping/saving
respects real validity.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 7a0db48c-3421-412e-9087-59a36a80e22c
📒 Files selected for processing (4)
ui/src/pages/deployment-details/deployment-details-form/deployment-details-form.tsxui/src/pages/project-details/delete-project-dialog.tsxui/src/pages/project-details/new-project-dialog.tsxui/src/pages/project-details/styles.module.scss
💤 Files with no reviewable changes (1)
- ui/src/pages/project-details/styles.module.scss
✅ Files skipped from review due to trivial changes (1)
- ui/src/pages/project-details/new-project-dialog.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Screenshots
Summary by CodeRabbit
New Features
UI/UX Improvements