You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
f-1257 add Editorial interface for questions - #1537
We need to scope this one a bit more. Here is what an older question looks like.
If a question does not have question_json then either the edit button should be disabled or we should create new question_json from the html.
Then, the edit button would ideally bring up the question in the assignment builder interface for editing. Or at a bare minimum an interface as shown, but with nicely formatted JSON to edit.
Other comments. This change appears to require both greenlets and the newer psycopg[binary] >= 3.2. I had to add those to pyproject.toml in the project file or else the admin server crashed on startup. - nevermind this appears to be a new dependency for a change in sqlalchemy.
We need to scope this one a bit more. Here is what an older question looks like.
If a question does not have `question_json` then either the edit button should be disabled or we should create new `question_json` from the html.
Then, the edit button would ideally bring up the question in the assignment builder interface for editing. Or at a bare minimum an interface as shown, but with nicely formatted JSON to edit.
Other comments. This change appears to require both greenlets and the newer psycopg[binary] >= 3.2. I had to add those to pyproject.toml in the project file or else the admin server crashed on startup. - nevermind this appears to be a new dependency for a change in sqlalchemy.
@bnmnetp
Thanks for the feedback. I’ve updated the implementation:
questions without question_json now disabled Edit button with a tooltip
questions with question_json open an editor containing formatted JSON
backend also rejects direct edit requests for questions without question_json
I didn't use the Assignment Builder because editorial questions may be unassigned, and editors don't necessarily have instructor or assignment context it requires
Would you prefer to use current JSON editor, or should I investigate integrating the Assignment Builder instead?
If Assignment Builder integration is preferred, how should unassigned questions and editors without instructor access be handled?
The greenlet and psycopg[binary] >= 3.2 dependencies are already present in previous PR 6a2e535. I synced my branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add editorial interface for questions marked for review:
f-1257.mp4