Skip to content

fix spirv-tools skipping C++ compile on install #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Firestar99 merged 1 commit into from
Feb 13, 2026
+4 −0
Merged

fix spirv-tools skipping C++ compile on install #141

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions crates/cargo-gpu-install/src/install.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,6 +284,10 @@ package = "rustc_codegen_spirv"

crate::user_output!("Compiling `rustc_codegen_spirv` from source {}\n", source);
let mut cargo = spirv_builder::cargo_cmd::CargoCmd::new();
// Make sure spirv-tools is build normally and does not skip C++ compile due to "being run in clippy"
// We add this only to our install and not generally to `CargoCmd` since we do want to forward clippy args
// to clippy running on the spirv target via e.g. `cargo gpu clippy`.
cargo.env_remove("CLIPPY_ARGS");
cargo
.current_dir(&install_dir)
.arg(format!("+{toolchain_channel}"))
Expand Down