Skip to content

Add reuse badge in readme. - #48

Merged
axeluhl merged 2 commits into
SAP:mainfrom
ajinkyapatil8190:patch-1
Aug 28, 2026
Merged

Add reuse badge in readme.#48
axeluhl merged 2 commits into
SAP:mainfrom
ajinkyapatil8190:patch-1

Conversation

@ajinkyapatil8190

@ajinkyapatil8190 ajinkyapatil8190 commented Aug 12, 2026

Copy link
Copy Markdown
Member

Add reuse badge in readme.

Issue Addressed by this PR

No Bug, just a chore for compliance.

Description

So, as per the OSPO guidelines, we have to make sure that the SAP open source repositories are all compliant - for this I created this PR to mark the compliance to the reuse rule.

Checklist for Pull Requests

  • Supplied as many details as possible on this change
  • Included the link to the associated Bugzilla issue in the Issue section above
  • New code has been formatted using the code formatter
  • The code has unit tests where applicable and is easily unit-testable
  • This branch is appropriately named for the associated issue, usually bugXXXX

Add reuse badge in readme.
@axeluhl

axeluhl commented Aug 12, 2026

Copy link
Copy Markdown
Member

@ajinkyapatil8190 does this need to go at the beginning of the file or can it appear anywhere?

@ajinkyapatil8190

ajinkyapatil8190 commented Aug 26, 2026

Copy link
Copy Markdown
Member Author

It can be anywhere in the file, but usually all badges are at the beginning of the readme so I kept it like that.
This PR is for compliance with reuse tool as mentioned in the description with the link to the wiki page with OSPO guidelines. @axeluhl

@axeluhl axeluhl left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. BTW, @ajinkyapatil8190 why would the tag as seen on https://github.com/ajinkyapatil8190/sailing-analytics/tree/patch-1 show "non-compliant?" How do we find out?

@axeluhl axeluhl left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; hope that after 0ed071e this triggers a build to fulfill the merge condition.

@axeluhl
axeluhl temporarily deployed to privileged-pr-build August 27, 2026 08:45 — with GitHub Actions Inactive
axeluhl added a commit that referenced this pull request Aug 27, 2026
The 'code' filter used only negated rules under the default 'some'
quantifier. picomatch treats '!README.md' as "any path except README.md",
so a changed README.md still matched a rule and set code=true, forcing a
full build for docs-only PRs (as seen on PR #48).

Add a positive '**' rule and set predicate-quantifier: 'every' (the pinned
v3.0.3 does not support the v4-only 'some-with-excludes'), so code is true
only when a changed file matches the '**' rule AND all '!' exclusions,
i.e. it is a non-trivial file.

Assisted-By: Claude Opus 4.8
axeluhl added a commit that referenced this pull request Aug 27, 2026
The 'code' filter used only negated rules under the default 'some'
quantifier. picomatch treats '!README.md' as "any path except README.md",
so a changed README.md still matched a rule and set code=true, forcing a
full build for docs-only PRs (as seen on PR #48).

Add a positive '**' rule and set predicate-quantifier: 'every' (the pinned
v3.0.3 does not support the v4-only 'some-with-excludes'), so code is true
only when a changed file matches the '**' rule AND all '!' exclusions,
i.e. it is a non-trivial file.

Assisted-By: Claude Opus 4.8
@axeluhl
axeluhl temporarily deployed to privileged-pr-build August 27, 2026 12:45 — with GitHub Actions Inactive
@axeluhl
axeluhl merged commit 8136938 into SAP:main Aug 28, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants