Fix seed boolean null handling#5870
Open
nkwork9999 wants to merge 1 commit into
Open
Conversation
5429717 to
673aa45
Compare
673aa45 to
197e06a
Compare
Signed-off-by: nkwork9999 <143652584+nkwork9999@users.noreply.github.com>
197e06a to
6f9744d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5589.
This preserves NULL values in seed boolean columns instead of coercing them to
False.The issue was caused by seed boolean conversion calling
str_to_bool(str(value))for every value. Pandas reads CSVnullvalues asNaN, so the seed renderer convertedNaNto the string"nan", andstr_to_bool("nan")returnedFalse.Changes
Nonewhen rendering seed boolean columns.null,false,true, andnullin a boolean column.Databricks validation
Verified on Databricks Free Edition / SQL Warehouse that Databricks preserves boolean NULL values with the expected SQL shape:
Result:
Also verified locally that SQLMesh now generates Databricks SQL preserving NULL values:
Tests