feat: Add Development Container and Windows specific development pre-requisites - #5894
Conversation
Signed-off-by: davem-bis <68955845+davem-bis@users.noreply.github.com>
…command in devcontainer. Signed-off-by: davem-bis <68955845+davem-bis@users.noreply.github.com>
Signed-off-by: davem-bis <68955845+davem-bis@users.noreply.github.com>
|
@davem-bis Thanks for this PR! Blocker
Optional
Let me know if I'm missing anything! |
|
Hi @StuffbyYuki, thanks for the review. Regarding the I'll implement the rest though. Regarding the SIGUSR1 rational, one of the tests fails on that import on Windows - I'll try to track down which one it is and see if I can tweak it. |
Signed-off-by: davem-bis <68955845+davem-bis@users.noreply.github.com>
|
Hi @StuffbyYuki - sorry for the delay. Those changes have been implemented. |
|
Thanks! The On Microsoft’s Ubuntu install steps still require adding If you agree, let's either drop |
…create-command.sh script. Signed-off-by: davem-bis <68955845+davem-bis@users.noreply.github.com>
Signed-off-by: davem-bis <68955845+davem-bis@users.noreply.github.com>
Signed-off-by: davem-bis <68955845+davem-bis@users.noreply.github.com>
|
Hi @StuffbyYuki - I had a deeper dig into this, I was mistaken before, the Microsoft package repository was being added by the Java and Docker-in-Docker features, not the base docker image. I've added an extra step to the install script to add the repository if it's not available, in case those features are removed from the development container configuration in the future. |
Description
Adds a development container for those working on Windows as the repository relies on Python functionality only available on UNIX systems.
Expands the
development.mddocumentation to include caveats with developing on Windows.Test Plan
Dev container was built from scratch and
make fast-testrun successfully.Checklist
make styleand fixed any issues[ ] I have added tests for my changes (if applicable)Not Applicablemake fast-test)git commit -s) per the DCO