Skip to content

Fix race condition in Time.test.ts timing assertions #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miccy merged 2 commits into from
Feb 3, 2026
Merged

Fix race condition in Time.test.ts timing assertions #18

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c2defde
Initial plan
Copilot Feb 3, 2026
80c8966
fix: Eliminate race condition in Time.test.ts timing assertions
Copilot Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions packages/common/test/Time.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,13 @@ import {
describe("Time", () => {
describe("createTime", () => {
test("now returns current time", () => {
const before = Date.now();
const time = createTime();
const now = Date.now();
// Allow small difference due to execution time
expect(time.now()).toBeGreaterThanOrEqual(now - 10);
expect(time.now()).toBeLessThanOrEqual(now + 10);
const after = Date.now();
const timeNow = time.now();
// time.now() should be between before and after with small tolerance
expect(timeNow).toBeGreaterThanOrEqual(before - 10);
expect(timeNow).toBeLessThanOrEqual(after + 10);
});

test("millisToDateIso returns current time as ISO string", () => {
Expand Down