[autobackport: sssd-2-12] Tests: Add integration tests validating SSSD socket#8564
[autobackport: sssd-2-12] Tests: Add integration tests validating SSSD socket#8564sssd-bot wants to merge 1 commit intoSSSD:sssd-2-12from
Conversation
Add integration tests validating SSSD socket activation behavior for individual responders and mixed socket/traditional configurations. Reviewed-by: Alexey Tikhonov <atikhono@redhat.com> Reviewed-by: Jakub Vávra <jvavra@redhat.com> (cherry picked from commit abee6e7)
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new suite of system tests for SSSD socket activation, covering responder lifecycles, autofs integration, mixed service configurations, and conflict handling. The review feedback correctly identifies missing assertions in several test cases where the implementation did not fully align with the docstrings' claims regarding initial service inactivity. Code suggestions were provided to ensure the service units are verified as inactive before the first request is triggered.
| service_unit = f"sssd-{responder}.service" | ||
|
|
||
| assert client.sssd.svc.is_active(socket_unit), f"{responder} socket should be active" | ||
|
|
There was a problem hiding this comment.
The test's docstring states that it verifies that the service unit is inactive initially. However, this check is missing from the test implementation. To ensure the test fully validates the socket activation lifecycle as described, an assertion should be added to confirm the service is not active before the first request is made.
| assert not client.sssd.svc.is_active(service_unit), f"{responder} service should be inactive before request" |
| service_unit = f"sssd-{responder}.service" | ||
|
|
||
| assert client.sssd.svc.is_active(socket_unit), f"{responder} socket should be active" | ||
|
|
There was a problem hiding this comment.
The test's docstring states that it verifies that the service unit is inactive initially. However, this check is missing from the test implementation. To ensure the test fully validates the socket activation lifecycle as described, an assertion should be added to confirm the service is not active before the first request is made.
| assert not client.sssd.svc.is_active(service_unit), f"{responder} service should be inactive before request" |
| socket_service = f"sssd-{socket_responder}.service" | ||
|
|
||
| assert client.sssd.svc.is_active(socket_unit), f"{socket_responder} socket should be active" | ||
|
|
There was a problem hiding this comment.
The test's docstring states that it verifies that the service unit is inactive initially. However, this check is missing from the test implementation. To ensure the test fully validates the socket activation lifecycle as described, an assertion should be added to confirm the service is not active before the first request is made.
| assert not client.sssd.svc.is_active(socket_service), f"{socket_responder} service should be inactive before request" |
4 participants
This is an automatic backport of PR#8481 Tests: Add integration tests validating SSSD socket to branch sssd-2-12, created by @aborah-sudo.
Please make sure this backport is correct.
Note
The commits were cherry-picked without conflicts.
You can push changes to this pull request
Original commits
abee6e7 - Tests: Add integration tests validating SSSD socket
Backported commits
Original Pull Request Body
Add integration tests validating SSSD socket activation behavior for individual responders and mixed socket/traditional configurations.