feat(cmd) add database-list-plans#1189
Conversation
1369e6f to
8b01765
Compare
matthieu526-scalingo
left a comment
There was a problem hiding this comment.
There is not ticket linked in the branch or the PR, won't that fail our internal compliance?
Also, why is this command required? Do we want to duplicate the command?
| SeeAlso: []string{"databases", "database-info", "database-create", "database-upgrade", "database-destroy"}, | ||
| }.Render(), | ||
| Action: func(ctx context.Context, c *cli.Command) error { | ||
| technology := c.Args().First() |
There was a problem hiding this comment.
question: do we want a failsafe on the technology? Because here nothing prevents to ask for SR plans, correct?
There was a problem hiding this comment.
Yes and I think it's still good at least for now. It'll be changed by DBFCC
I've linked the related story, is its content answering to your questions? |
| SeeAlso: []string{"databases", "database-info", "database-create", "database-upgrade", "database-destroy"}, | ||
| }.Render(), | ||
| Action: func(ctx context.Context, c *cli.Command) error { | ||
| technology := c.Args().First() |
Yes thanks, it totally answers the question. I approved already. |
Yes I could have used alias but IMO it's worth it to have this duplication for both: 1. specify "database" error 2. already have the preview command. We'll just have to change the logic behind. |
Uh oh!
There was an error while loading. Please reload this page.