Skip to content

Comments

feat(cmd) add database-list-plans#1189

Merged
curzolapierre merged 1 commit intomasterfrom
feat/cmd/database-list-plans
Feb 20, 2026
Merged

feat(cmd) add database-list-plans#1189
curzolapierre merged 1 commit intomasterfrom
feat/cmd/database-list-plans

Conversation

@curzolapierre
Copy link
Member

@curzolapierre curzolapierre commented Feb 19, 2026

➜  scalingo database-list-plans postgresql-ng
┌────────────────────────────────────┬────────────────────┐
│                 ID                 │        NAME        │
├────────────────────────────────────┼────────────────────┤
│ postgresql-ng-starter-1024         │ Starter 1G         │
│ postgresql-dr-starter-4096         │ Starter 4G         │
│ postgresql-dr-business-4096        │ Business 4G        │
│ postgresql-ng-enterprise-4096      │ Enterprise 4G      │
└────────────────────────────────────┴────────────────────┘
  • Add a changelog entry in the section "To Be Released" of CHANGELOG.md

@curzolapierre curzolapierre self-assigned this Feb 19, 2026
@curzolapierre curzolapierre force-pushed the feat/cmd/database-list-plans branch from 1369e6f to 8b01765 Compare February 19, 2026 14:28
@curzolapierre curzolapierre marked this pull request as ready for review February 19, 2026 14:28
Copy link
Contributor

@matthieu526-scalingo matthieu526-scalingo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is not ticket linked in the branch or the PR, won't that fail our internal compliance?
Also, why is this command required? Do we want to duplicate the command?

SeeAlso: []string{"databases", "database-info", "database-create", "database-upgrade", "database-destroy"},
}.Render(),
Action: func(ctx context.Context, c *cli.Command) error {
technology := c.Args().First()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: do we want a failsafe on the technology? Because here nothing prevents to ask for SR plans, correct?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes and I think it's still good at least for now. It'll be changed by DBFCC

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright.

@notion-workspace
Copy link

@curzolapierre
Copy link
Member Author

There is not ticket linked in the branch or the PR, won't that fail our internal compliance?
Also, why is this command required? Do we want to duplicate the command?

I've linked the related story, is its content answering to your questions?

SeeAlso: []string{"databases", "database-info", "database-create", "database-upgrade", "database-destroy"},
}.Render(),
Action: func(ctx context.Context, c *cli.Command) error {
technology := c.Args().First()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright.

@matthieu526-scalingo
Copy link
Contributor

There is not ticket linked in the branch or the PR, won't that fail our internal compliance?
Also, why is this command required? Do we want to duplicate the command?

I've linked the related story, is its content answering to your questions?

Yes thanks, it totally answers the question. I approved already.
One nitpick question, is it possible to create aliases for commands? In order not to duplicate the code, but create just a reference?

@curzolapierre
Copy link
Member Author

One nitpick question, is it possible to create aliases for commands? In order not to duplicate the code, but create just a reference?

Yes I could have used alias but IMO it's worth it to have this duplication for both: 1. specify "database" error 2. already have the preview command. We'll just have to change the logic behind.

@curzolapierre curzolapierre merged commit 21387e3 into master Feb 20, 2026
7 checks passed
@curzolapierre curzolapierre deleted the feat/cmd/database-list-plans branch February 20, 2026 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants