Repository navigation
Validate search sample limits and bump evo-compute to 0.0.7 - #406
Open
amirabbas-jalali-bentley wants to merge 3 commits into
Open
amirabbas-jalali-bentley wants to merge 3 commits into
amirabbas-jalali-bentley wants to merge 3 commits into
Conversation
Require max_samples to be at least 1, and require min_samples (when set) to be between 1 and max_samples.
amirabbas-jalali-bentley
requested review from
BehrangKousha,
aminabedi-bentley,
diegoraf-bsy and
higordearaujo-bsy
November 14, 2026 01:08
Bump evo-compute from 0.0.6 to 0.0.7 and update uv.lock.
amirabbas-jalali-bentley
force-pushed
the
validate-search-sample-limits
branch
from
November 14, 2026 01:25
3559bd4 to
dbecb4b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
SearchNeighborhoodpreviously accepted invalid sample limits such asmax_samples=0,min_samples=0, andmin_samplesgreater thanmax_samples. This enforces those bounds on the sharedSearchNeighborhoodmodel so all compute task clients reject unsupported configurations before submitting a job, and bumpsevo-computefrom0.0.6to0.0.7for release.Changes
max_samples >= 1and, whenmin_samplesis set, require1 <= min_samples <= max_samplesonSearchNeighborhood(min_samplesstill defaults toNoneand is omitted when unset).max_samples=0,min_samples=0,min_samples > max_samples) and valid boundary values (max_samples=1,min_samples=None,min_samples=1,min_samples=max_samples) acrossSearchNeighborhood,KrigingParameters,IDWParameters, andKNNParameters.evo-computeto0.0.7inpackages/evo-compute/pyproject.tomlanduv.lock(also syncingevo-sdk-commonto0.5.32inuv.lockafter Sync up pyproject with release version #403). This prepares a release including:SearchNeighborhood.DiscoveryClient, Add a discovery client for compute tasks #387).Validation
uv run --locked --package evo-compute pytest packages/evo-compute/tests -q— passed (525 passed, 160 subtests passed).uv run --only-dev ruff check— passed.uv run --only-dev ruff format --check— passed.uv build --package evo-compute— passed (wheel and source distribution).evo-sdk-common0.5.32,evo-blockmodels0.9.0,evo-objects0.6.6) — passed (525 passed, 160 subtests passed).uv tool run --from uv==0.9.7 uv lock --check— passed.uv run --locked --no-sync pre-commit run --files packages/evo-compute/src/evo/compute/tasks/common/search.py packages/evo-compute/tests/test_tasks.py packages/evo-compute/tests/geostatistics/test_kriging_tasks.py packages/evo-compute/tests/geostatistics/test_idw_tasks.py packages/evo-compute/tests/geostatistics/test_knn_tasks.py packages/evo-compute/pyproject.toml uv.lock— passed.git diff --check— passed.Checklist