Skip to content

Validate search sample limits and bump evo-compute to 0.0.7 - #406

Open
amirabbas-jalali-bentley wants to merge 3 commits into
SeequentEvo:mainfrom
amirabbas-jalali-bentley:validate-search-sample-limits
Open

amirabbas-jalali-bentley wants to merge 3 commits into
SeequentEvo:mainfrom
amirabbas-jalali-bentley:validate-search-sample-limits

Conversation

@amirabbas-jalali-bentley

Copy link
Copy Markdown
Contributor

Description

SearchNeighborhood previously accepted invalid sample limits such as max_samples=0, min_samples=0, and min_samples greater than max_samples. This enforces those bounds on the shared SearchNeighborhood model so all compute task clients reject unsupported configurations before submitting a job, and bumps evo-compute from 0.0.6 to 0.0.7 for release.

Changes

  • Require max_samples >= 1 and, when min_samples is set, require 1 <= min_samples <= max_samples on SearchNeighborhood (min_samples still defaults to None and is omitted when unset).
  • Add regression tests for invalid limits (max_samples=0, min_samples=0, min_samples > max_samples) and valid boundary values (max_samples=1, min_samples=None, min_samples=1, min_samples=max_samples) across SearchNeighborhood, KrigingParameters, IDWParameters, and KNNParameters.
  • Bump evo-compute to 0.0.7 in packages/evo-compute/pyproject.toml and uv.lock (also syncing evo-sdk-common to 0.5.32 in uv.lock after Sync up pyproject with release version #403). This prepares a release including:

Validation

  • uv run --locked --package evo-compute pytest packages/evo-compute/tests -q — passed (525 passed, 160 subtests passed).
  • uv run --only-dev ruff check — passed.
  • uv run --only-dev ruff format --check — passed.
  • uv build --package evo-compute — passed (wheel and source distribution).
  • Built-wheel tests in an isolated environment against published PyPI dependencies (evo-sdk-common 0.5.32, evo-blockmodels 0.9.0, evo-objects 0.6.6) — passed (525 passed, 160 subtests passed).
  • uv tool run --from uv==0.9.7 uv lock --check — passed.
  • uv run --locked --no-sync pre-commit run --files packages/evo-compute/src/evo/compute/tasks/common/search.py packages/evo-compute/tests/test_tasks.py packages/evo-compute/tests/geostatistics/test_kriging_tasks.py packages/evo-compute/tests/geostatistics/test_idw_tasks.py packages/evo-compute/tests/geostatistics/test_knn_tasks.py packages/evo-compute/pyproject.toml uv.lock — passed.
  • git diff --check — passed.

Checklist

  • I have read the contributing guide and the code of conduct

Require max_samples to be at least 1, and require min_samples (when set) to be between 1 and max_samples.
Bump evo-compute from 0.0.6 to 0.0.7 and update uv.lock.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant