a couple places where ArtQRCode creates a short lived Bitmap but neve…#695
Open
danFbach wants to merge 1 commit intoShane32:masterfrom
Open
a couple places where ArtQRCode creates a short lived Bitmap but neve…#695danFbach wants to merge 1 commit intoShane32:masterfrom
danFbach wants to merge 1 commit intoShane32:masterfrom
Conversation
…r disposes of it and orphans the GDI+ handle, leading to handle exhaustion in some cases.
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughUpdated resource management in ArtQRCode class by wrapping intermediate Bitmap allocations in Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…r disposes of it and orphans the GDI+ handle, leading to handle exhaustion in some cases.
Summary
wraps internal throw away bitmaps in using blocks so that they are disposed of.
This PR fixes/implements the following bugs/features:
What existing problem does the pull request solve?
when i recursively generate ArtQRCode(s) i get handle exhaustion errors which show themselves as "A generic error occurred in GDI+."
Test plan
Passes project unit tests. Simple using blocks added to internal objects only, so it should not change how anything works.
Closing issues
didn't create an issue.
Summary by CodeRabbit