fix: store plugin traces in payload workspace - #254
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cwdin the normalized hook payload whenAGENT_TRACE_DIRis unsetAGENT_TRACE_DIRprecedence and legacy fallback behavior for missing or invalid payload directoriesagent-strace:trace-analystagent and bump plugin/package metadata to 0.94.1Root cause
Marketplace hooks execute with the installed plugin directory as their process cwd. The hook store default was the relative path
.agent-traces, so plugin-triggered sessions were written beneath the installation directory even though Copilot supplies the repository cwd in every official hook payload.Validation
PYTHONPATH=src python3 -m unittest discover -s tests -p 'test_*hooks.py' -v(62 passed)agent-strace@agent-trace (v0.94.1); invoking the installed hook from the plugin directory creates the trace only at<payload cwd>/.agent-traces/varsymlink path-safety checks in assignment/compliance tests