Fixed RIS valve displacement interpolation issue with different mesh scale factors#541
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #541 +/- ##
=======================================
Coverage 68.15% 68.15%
=======================================
Files 174 174
Lines 34160 34187 +27
Branches 5932 5935 +3
=======================================
+ Hits 23281 23301 +20
- Misses 10742 10749 +7
Partials 137 137 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR addresses incorrect URIS_displacement output for URIS/RIS valves when simulations use different mesh scale factors and run in parallel, by improving how immersed surface nodes are localized into fluid elements and how displacement is interpolated and reduced across MPI ranks.
Changes:
- Reworked
uris_update_disp()to avoid multi-rank double-counting by electing a single owning rank per immersed node and only letting that rank contribute to the MPI reduction. - Made element-containment checks more scale-aware (bounding-box tolerance + boundary handling) to stabilize localization across mesh scales.
- Cleaned up URIS helper APIs (return types/const-correctness) and related comments/struct members.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| Code/Source/solver/uris.h | Updates URIS helper function signatures (bool returns, const refs) and removes stale inline notes. |
| Code/Source/solver/uris.cpp | Implements owner-rank election for URIS displacement interpolation, adjusts localization tolerances, and updates geometry containment utilities. |
| Code/Source/solver/ComMod.h | Updates urisType fields/comments to support the new ownership flag (localNode) and cleans up URIS documentation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
3aa5da9 to
6605c7e
Compare
|
@codex review for the owner-rank tie-breaker in uris_update_disp, especially the equal local_metric case from the Copilot thread. |
… element for an RIS valve node
aabrown100-git
left a comment
There was a problem hiding this comment.
Looks good to me now!
zinanhu0810
left a comment
There was a problem hiding this comment.
These changes look good to me.
|
Shall we merge? |
|
@aabrown100-git Yes, I think it's ready to merge. Thanks! |
Resolves #461
Release Notes
uris_update_dispfunction.Code of Conduct & Contributing Guidelines