Skip to content

feat(aggregation): Make Aggregator and Weighting subclasses public#670

Merged
ValerianRey merged 3 commits into
mainfrom
make-weighted-aggregator-public
May 7, 2026
Merged

feat(aggregation): Make Aggregator and Weighting subclasses public#670
ValerianRey merged 3 commits into
mainfrom
make-weighted-aggregator-public

Conversation

@ValerianRey
Copy link
Copy Markdown
Contributor

@ValerianRey ValerianRey commented May 7, 2026

  • Export WeightedAggregator, GramianWeightedAggregator, MatrixWeighting, and GramianWeighting from torchjd.aggregation (added to __all__ and documented in index.rst)
  • Update all aggregator and weighting docstrings to reference the most specific public base class (e.g. GramianWeightedAggregator instead of Aggregator, GramianWeighting instead of Weighting)
  • Update internal imports that used the private _aggregator_bases path to use the public torchjd.aggregation path
  • Make the combine method protected
  • Add changelog entry

…, MatrixWeighting, and GramianWeighting public

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@ValerianRey ValerianRey requested review from a team and PierreQuinton as code owners May 7, 2026 21:36
@ValerianRey ValerianRey marked this pull request as draft May 7, 2026 21:37
@ValerianRey ValerianRey added cc: feat Conventional commit type for new features. package: aggregation labels May 7, 2026
@ValerianRey ValerianRey changed the title feat(aggregation): Make WeightedAggregator, GramianWeightedAggregator, MatrixWeighting, and GramianWeighting public feat(aggregation): Make Aggregator and Weighting subclasses public May 7, 2026
@ValerianRey ValerianRey marked this pull request as ready for review May 7, 2026 21:43
Comment thread src/torchjd/aggregation/_aggregator_bases.py Outdated
Comment thread src/torchjd/aggregation/_aggregator_bases.py Outdated
ValerianRey and others added 2 commits May 8, 2026 01:50
Co-authored-by: Valérian Rey <31951177+ValerianRey@users.noreply.github.com>
@ValerianRey ValerianRey merged commit eeff844 into main May 7, 2026
16 checks passed
@ValerianRey ValerianRey deleted the make-weighted-aggregator-public branch May 7, 2026 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cc: feat Conventional commit type for new features. package: aggregation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant