Skip to content

test: Clean up trajectories#694

Merged
ValerianRey merged 5 commits into
mainfrom
clean-up-trajectories
May 20, 2026
Merged

test: Clean up trajectories#694
ValerianRey merged 5 commits into
mainfrom
clean-up-trajectories

Conversation

@ValerianRey
Copy link
Copy Markdown
Contributor

@ValerianRey ValerianRey commented May 20, 2026

The idea behind this is to keep the trajectories package clean, with only the experiments that we pushed enough to put them in the paper.

Summary

  • Rename QuadraticFormQuadraticFunction (and subclasses) — these are not quadratic forms in the linear-algebra sense
  • Remove the CQF, MN2, and MN20 objective configurations and all their associated constants
  • Remove the nashmtl20 aggregator and its constants
  • Rename CQF2CQF
  • Add a usage example to run all trajectories of the paper at once

🤖 Generated with Claude Code

@ValerianRey ValerianRey requested a review from a team as a code owner May 20, 2026 20:57
@ValerianRey ValerianRey added the cc: test Conventional commit type for changes to tests. label May 20, 2026
@github-actions github-actions Bot changed the title refactor(trajectories): Clean up objectives and aggregators test: Clean up objectives and aggregators May 20, 2026
@ValerianRey ValerianRey changed the title test: Clean up objectives and aggregators test: Clean up trajectories May 20, 2026
@ValerianRey ValerianRey requested a review from PierreQuinton May 20, 2026 21:03
Copy link
Copy Markdown
Contributor

@PierreQuinton PierreQuinton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not have much expertise on this part of the repo, I think it is fine if it runs correctly.

@ValerianRey ValerianRey merged commit 5101241 into main May 20, 2026
17 of 19 checks passed
@ValerianRey ValerianRey deleted the clean-up-trajectories branch May 20, 2026 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cc: test Conventional commit type for changes to tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants