chore: Remove stale CUBLAS_WORKSPACE_CONFIG requirement#697
Merged
Conversation
Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
PierreQuinton
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CUBLAS_WORKSPACE_CONFIG=:4096:8appeared in three places (CONTRIBUTING.md,tests/profiling/run_profiler.py,tests/profiling/speed_grad_vs_jac_vs_gram.py) but is no longer needed. This PR removes it.History
Initial squashed commit (June 2024):
tests/unit/conftest.pycalledtorch.use_deterministic_algorithms(True)unconditionally for all devices.CUBLAS_WORKSPACE_CONFIG=:4096:8is required by cuBLAS when deterministic mode is enabled on CUDA, so the variable was necessary.Commit
83d2e046("Add command for cuda unit tests in CONTRIBUTING.md"): Added theCUBLAS_WORKSPACE_CONFIG=:4096:8instruction toCONTRIBUTING.mdfor running unit tests on CUDA — correct at the time.PR feat: add
autogram.Engine(batched) #387 / commitd1594301("feat: addautogram.Engine(batched)", Aug 2025): Changedconftest.pyto only calltorch.use_deterministic_algorithms(True)on CPU, with an explicit comment explaining why ("we also use GPU to benchmark algorithms, and we would rather have them use non-deterministic but faster algorithms"). The commit message even lists "Force using deterministic algorithms only on CPU" under the Testing section. However,CUBLAS_WORKSPACE_CONFIGwas left behind in all three places — an oversight.Since PR #387,
CUBLAS_WORKSPACE_CONFIGhas been unnecessary:tests/trajectories/optimize.py: does calluse_deterministic_algorithms(True)unconditionally, but all its tensors are CPU-only (the script ends with.numpy()calls), so cuBLAS is never involved.🤖 Generated with Claude Code