firstled_switch: Updated min_api_version to 20 for out of date tests#3051
Merged
Conversation
|
Channel deleted. |
Test Results 73 files 517 suites 0s ⏱️ Results for commit 2fe8e39. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against dae7b10 |
Contributor
|
What exactly in v19 is an issue for these tests? |
Contributor
Author
In V19 the test.socket.capability:__expect_send(mock_parent:generate_test_message("main",
capabilities.button.numberOfButtons({ value = 1 }, { visibility = { displayed = false } })))
test.socket.capability:__expect_send(mock_parent:generate_test_message("main",
capabilities.button.supportedButtonValues({ "pushed" }, { visibility = { displayed = false } })))I suppose this is an area I should duplicate the tests and fork on API version, but since these changes were merged and tested against 61 (v20) I think it'd be fine to just update the broken tests to 20. |
cjswedes
approved these changes
Jun 25, 2026
aleclorimer
force-pushed
the
firstled-test-min_api_version-fix
branch
from
2fe8e39 to
dae7b10
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the tests to
min_api_version = 20from 19. Resolves 14 failing tests in version 60.Related PR: #2971