Skip to content

MangaBaka: handle 404 cover image fetch gracefully #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gregoryn22 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

MangaBaka: handle 404 cover image fetch gracefully #302

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 18 additions & 6 deletions komf-core/src/commonMain/kotlin/snd/komf/providers/mangabaka/MangaBakaMetadataProvider.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,12 @@
package snd.komf.providers.mangabaka

import io.github.oshai.kotlinlogging.KotlinLogging
import io.github.reactivecircus.cache4k.Cache
import io.ktor.client.HttpClient
import io.ktor.client.call.body
import io.ktor.client.plugins.ClientRequestException
import io.ktor.client.request.get
import io.ktor.http.HttpStatusCode
import io.ktor.http.contentType
import snd.komf.model.Image
import snd.komf.model.MatchQuery
Expand All @@ -18,6 +21,8 @@ import snd.komf.providers.MetadataProvider
import snd.komf.util.NameSimilarityMatcher
import kotlin.time.Duration.Companion.minutes

private val logger = KotlinLogging.logger {}

class MangaBakaMetadataProvider(
private val dataSource: MangaBakaDataSource,
private val metadataMapper: MangaBakaMetadataMapper,
Expand Down Expand Up @@ -103,12 +108,19 @@ class MangaBakaMetadataProvider(

private suspend fun fetchCover(series: MangaBakaSeries): Image? {
if (coverFetchClient == null || series.cover.x350?.x1 == null) return null

val response = coverFetchClient.get(series.cover.x350.x1)
return Image(
response.body(),
response.contentType()?.let { "${it.contentType}/${it.contentSubtype}" }
)
val url = series.cover.x350.x1
return try {
val response = coverFetchClient.get(url)
Image(
response.body(),
response.contentType()?.let { "${it.contentType}/${it.contentSubtype}" }
)
} catch (e: ClientRequestException) {
if (e.response.status == HttpStatusCode.NotFound) {
logger.warn { "Cover image not found for series '${series.title}' (${e.response.status}), continuing without cover" }
null
} else throw e
}
}

private fun ProviderSeriesId.toMangaBakaId() = MangaBakaSeriesId(this.value.toInt())
Expand Down