Repository navigation
Use server-provided scan report links - #399
Open
John-David Dalton (jdalton) wants to merge 1 commit into
Open
John-David Dalton (jdalton) wants to merge 1 commit into
John-David Dalton (jdalton) wants to merge 1 commit into
Conversation
John-David Dalton (jdalton)
added this pull request to stack #400
October 13, 2026 16:27
John-David Dalton (jdalton)
force-pushed
the
fix/python-server-report-urls
branch
from
October 13, 2026 16:35
85170a0 to
b8b6d48
Compare
John-David Dalton (jdalton)
force-pushed
the
fix/python-server-report-urls
branch
from
October 13, 2026 16:49
b8b6d48 to
d3b0c22
Compare
John-David Dalton (jdalton)
removed this pull request from stack #400
October 13, 2026 16:58
John-David Dalton (jdalton)
added this pull request to stack #401
October 13, 2026 16:58
This was referenced Oct 13, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LLM Description written by Codex:GPT-6
Use the report links returned by Socket so Python CLI results point to the correct comparison and scans, including alternate deployments.
Root Cause
The CLI built dashboard URLs from scan IDs instead of preserving the API response. Appending query strings also broke links that already had query parameters or fragments.
Fix
Builds on #398; merge after its parent. This PR does not change output schemas or publish a release.
Validation and limits
All 36 focused pure and real local HTTP tests pass. Scoped Ruff passes. Pytest reports two pre-existing unknown asyncio configuration warnings. The tests exercise the real CLI core and SDK. The streaming SDK does not expose the old and new scan URLs; known scan-creation URLs are retained where available.
Public Changelog
Use server-provided report links and preserve their query parameters in Python CLI output.
Note
Medium Risk
Changes how every user-facing report URL is built across diff, full-scan, and notification paths; incorrect handling could break CI links or point to wrong reports, but does not touch auth or scan data.
Overview
Report links now come from the Socket API instead of hard-coded
socket.dev/dashboard/org/.../sbom/{id}URLs, so CLI output works with alternate deployments and the links the server actually serves.Diff and full-scan flows populate
diff_url,old_scan_url, andnew_scan_urlonDiff(and on comparison result types) from polled diff-scanhtml_url/ nested full-scan metadata, with ID checks before trusting nested scan URLs. Streaming diff fallback keepsdiff_report_urlfrom the SDK.include_license_details=falseis applied via a newadd_query_paramshelper so existing query strings and fragments are preserved.PR comments, manifest file links, Slack, and Jira now use
Messages.get_view_report_urland omit links when URLs are missing. Tests cover URL normalization, query merging, and end-to-end diff URL behavior.Reviewed by Cursor Bugbot for commit b8b6d48. Configure here.