Prototype - potential code design for the new design - #749
Draft
SharonStrats wants to merge 8 commits into
Draft
Conversation
Prompt: Move the history logic into it's own function Co-authored-by: GPT-5.4 Mini <gpt-5.4-mini@openai.com>
Prompt: Move the opening logic in gotosubject into it's own function Co-authored-by: GPT-5.4 Mini <gpt-5.4-mini@openai.com>
…emanager for backward compatibility
Prompt: many different prompts asking specific questions about the code Co-authored-by: GPT-5.4 Mini <gpt-5.4-mini@openai.com>
…@5.0.0-0 pane-registry@5.0.0-0 activitystreams-pane@2.0.0-0 chat-pane@4.0.0-0 contacts-pane@4.0.0-0 folder-pane@4.0.0-0 issue-pane@4.0.0-0 meeting-pane@4.0.0-0 profile-pane@4.0.0-0 source-pane@4.0.0-0) (latest: rdflib@2.4.0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just playing around with the implementation of the new design to see what we should do and so we can discuss and find missing features.
I have also made lots of comments for now to make it easier to reason about the code and whether we should keep or change it. If we use the work from this branch in the end I will remove all the comments and clean it up.
This is not final and may even be thrown away.
This goes along with the same branch in the folder-pane.
Some questions are how far do we want to go to simplify the OutlineManager. How much do we need to keep in manager and how much can we bring into the folder-pane.
I haven't gotten there yet, but I'm wondering also if we want to bring in more web components ... could gotoSubject functionality be brought into one for instance, this is the main function used by the folder-pane, my gut is it needs to stay in solid-panes but I'm not completely sure yet.
Note: The commits are done in a way to show what steps I've taken so far.