Centralize add_segment and segments to BaseExtractor#4462
Open
alejoe91 wants to merge 21 commits intoSpikeInterface:mainfrom
Open
Centralize add_segment and segments to BaseExtractor#4462alejoe91 wants to merge 21 commits intoSpikeInterface:mainfrom
add_segment and segments to BaseExtractor#4462alejoe91 wants to merge 21 commits intoSpikeInterface:mainfrom
Conversation
This was referenced Mar 23, 2026
| return len(self._segments) | ||
|
|
||
| def get_parent(self) -> BaseExtractor | None: | ||
| def get_parent(self) -> "BaseExtractor | None": |
Member
There was a problem hiding this comment.
Hello. If you keep from __future__ import annotations you don't need to use string literals for self-referencing types. I think this is preferred, but might just be a style choice. At Python 3.11 we get a new type Self which is now the modern way to do self referencing.
Member
Author
There was a problem hiding this comment.
Ah nice! I would say we keep the string notation and get rid of future annotations. The main reason is that the __future__ import doesn't actually do any check, so we had a lot of bad typing (e.g., lists of | instead of Literal). This enforces us to be cleaner ;)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and fix a bunch of typing errors
Pulled out of #4216