Repository navigation
Fix: do not use set_times in OpenEphys timestamps loading (and load as memmap) - #4883
Merged
chrishalcrow merged 1 commit intoOct 20, 2026
Merged
Conversation
alejoe91
added
bug
chrishalcrow
approved these changes
Oct 20, 2026
This was referenced Oct 20, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #4671, the
set_timesfunction makes timestamps be dumped to dict. The only reader that was setting times withset_timeswas the Open Ephys reader.This PR directly sets the segment's time vector and further loads the timestamps in read memmap mode.