Merged
Conversation
f559c96 to
3a5efb7
Compare
3a5efb7 to
987733e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative approach to #1 — uses a compiler pass instead of a bundle, so end users don't need to touch
bundles.php.Ref: Sylius/Sylius#18588
Uses a compiler pass that plugins register in their
build()method. WhenSyliusCoreExtensionskips loading telemetry services (because the user disabled telemetry via ENV or config), the compiler pass loads them directly from SyliusCoreBundle.This approach requires no action from end users — no
bundles.phpchanges, no Flex recipe. The plugin'scomposer require sylius/telemetry+ compiler pass registration is enough.How it works
TelemetrySendManagerInterfacedoesn't exist) → noopSyliusCoreBundle/Resources/config/services/telemetry/viaDirectoryLoader(supports both XML and PHP formats)Usage in a plugin