Telemetry for official plugins #1
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rafikooo
changed the title
Rafikooo
force-pushed
the
add-telemetry-pass
branch
from
8daeb6c to
9a98bcc
Compare
Rafikooo
changed the title
Rafikooo
changed the title
Rafikooo
force-pushed
the
add-telemetry-pass
branch
from
9a98bcc to
36226dd
Compare
Rafikooo
changed the title
Rafikooo
force-pushed
the
add-telemetry-pass
branch
14 times, most recently
from
84c1e0b to
bd99ac4
Compare
Rafikooo
changed the title
Rafikooo
force-pushed
the
add-telemetry-pass
branch
9 times, most recently
from
b7fc5c9 to
1856185
Compare
Rafikooo
force-pushed
the
add-telemetry-pass
branch
3 times, most recently
from
75992b9 to
ce3b304
Compare
Rafikooo
force-pushed
the
add-telemetry-pass
branch
from
ce3b304 to
1dec85d
Compare
Rafikooo
force-pushed
the
add-telemetry-pass
branch
from
2d93f37 to
ca158a3
Compare
Collaborator
Author
|
I'm closing in favor of: #4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses
PrependExtensionInterfaceto enable telemetry beforeSyliusCoreExtensionprocesses its config. This covers both disable paths:SYLIUS_TELEMETRY_ENABLED=0) — overrides$_ENVand$_SERVERto'1'sylius_core.telemetry.enabled: false) — prepends config withenabled: trueA compiler pass alone wouldn't work because
SyliusCoreExtension::configureTelemetry()skips loading telemetry services entirely when ENV is disabled — by the time a compiler pass runs, services are already missing.Dev/test environments are skipped.
Compatibility
Composer constraints support Sylius ^1.12 with Symfony ^5.4. For Sylius versions older than 1.12.20 / 1.13.12 / 1.14.14 (before telemetry was added), the extension checks
interface_exists(TelemetrySendManagerInterface::class)and gracefully skips if telemetry is not available.CI only covers Sylius 1.14+ and 2.x because
sylius/test-applicationdoes not exist for 1.12/1.13. TheisTelemetrySupported()guard is unit-tested separately.