test(compare): match the row-limit sentinel read and the grid-drawn compare rows - #2859
Merged
Merged
Conversation
…k, and the structure script's stale schema (#2860) * fix(compare): compare every key both sides were read past under a row limit * fix(compare): refuse a comparison of one scope against itself before it deadlocks * feat(compare): refuse a structure script when an object changed after it was compared
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Automations to automatically generate PRs for you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mainis red after #2854. Four unit tests still describe the code as it was before two changes in that PR landed.The sentinel read. A row-limited side reads
limit + 1rows and never hands the last one out, so "this side ended exactly at the limit" is the server's own answer rather than a guess from the row count. ThreeKeyOrderedQueryScopeTestscases still expectLIMIT 100,LIMIT 50,FETCH NEXT 10andTOP 10.The compare rows pane. It renders its values through
DataGridViewnow, which takes its cell font fromThemeEngine.dataGridFontsinDataGridCellPalette, the same settingvalueFontreturns.ValueFontTestsstill lists the pane among the views that must name the font themselves, and a pane that renders no value of its own has nothing to name.Tests only. No behaviour changes.
Verified:
KeyOrderedQueryScopeTestsandValueFontTests, 18 executed, 18 passed.