Repository navigation
test: cover runtime error followed by a result set (#37) - #39
Merged
Merged
Conversation
Regression test for batches where a runtime error precedes a result set. With mssql-tiberius-bridge/mssql-tds 0.2.0 the server error is returned instead of 'Expected ColumnMetadata in context' or a hang. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
saurabh500
added
the
prerelease:beta
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #37.
The bridge/TDS upgrade to 0.2.0 (#38) fixes the
drain_streamproblem: a runtime error followed by a result set in the same batch now returns the real server error instead ofExpected ColumnMetadata in contextor a hang.This adds a live-DB regression test,
runtime_error_followed_by_result_set_returns_server_error, covering:execute_querywithSELECT 1/0; SELECT 2→ error 8134update_recordandinsert_recordhitting a CHECK constraint (547) before the trailingSELECT @@ROWCOUNTupdate_recordwith the same batch shape, to check the healthy path still worksA CHECK constraint is used instead of the issue's
REALoverflow because the overflow doesn't trigger on newer compatibility levels.Validation
cargo test --test live_db runtime_error_followed_by_result_set -- --test-threads=1passes on the current upgraded crates.mssql-tiberius-bridge 0.1.0-preview.5/mssql-tds-preview 0.1.0-preview.1) withSQL Server connection failure: IO error: Expected ColumnMetadata in context, which shows that it catches the original bug.