fix: modernize partner integration add-ons#490
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
🚧 Files skipped from review as they are similar to previous changes (5)
📝 WalkthroughWalkthroughThe PR modernizes generated Clerk and WorkOS integrations for TanStack Start, preserves existing environment values, removes persisted secret values, updates Railway and pnpm templates, changes Sentry defaults, and adds scaffold-generation tests. ChangesPartner add-on modernization
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant User
participant SignInRoute
participant WorkOSAuthKit
participant CallbackRoute
User->>SignInRoute: Request sign-in with returnPathname
SignInRoute->>WorkOSAuthKit: Generate sign-in URL
WorkOSAuthKit-->>SignInRoute: Return URL
SignInRoute-->>User: 307 redirect
User->>CallbackRoute: OAuth callback
CallbackRoute->>WorkOSAuthKit: Handle callback
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
packages/create/tests/partner-addons.test.tsParsing error: "parserOptions.project" has been provided for Comment |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
packages/create/src/frameworks/solid/hosts/railway/package.json (1)
6-6: 🩺 Stability & Availability | 🔵 Trivial | ⚡ Quick winPin Nitro to a tested stable version.
"latest"makes generated Railway apps resolve different Nitro releases over time, so a scaffold can change behavior or stop building after a reinstall. Use the exact stable version covered by the Railway validation matrix and upgrade it deliberately.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/create/src/frameworks/solid/hosts/railway/package.json` at line 6, Update the Nitro dependency in the Railway host template package configuration from “latest” to the exact stable version covered by the Railway validation matrix, preserving deliberate version pinning for reproducible generated apps.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/create/src/frameworks/react/add-ons/clerk/README.md`:
- Around line 22-34: Update the README’s /dashboard beforeLoad example to call a
createServerFn(...).handler(...) server function that performs auth() and
returns the authorization or redirect state, rather than invoking auth()
directly in beforeLoad. Keep the unauthenticated redirect behavior unchanged.
In `@packages/create/src/frameworks/solid/add-ons/sentry/package.json`:
- Line 3: Regenerate the Solid Sentry worker manifest represented by the
generated add-on module so its emitted dependency matches the source manifest’s
`@sentry/solid` version ^10.67.0. Update the generated output associated with the
Solid Sentry add-on, preserving its existing structure and other dependency
entries.
---
Nitpick comments:
In `@packages/create/src/frameworks/solid/hosts/railway/package.json`:
- Line 6: Update the Nitro dependency in the Railway host template package
configuration from “latest” to the exact stable version covered by the Railway
validation matrix, preserving deliberate version pinning for reproducible
generated apps.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: fd25ec76-17c9-4351-832d-aca5b49bdb44
📒 Files selected for processing (45)
.changeset/fresh-partner-paths.mdpackages/create/src/add-to-app.tspackages/create/src/config-file.tspackages/create/src/frameworks/react/add-ons/clerk/README.mdpackages/create/src/frameworks/react/add-ons/clerk/assets/_dot_env.local.appendpackages/create/src/frameworks/react/add-ons/clerk/assets/src/integrations/clerk/header-user.tsxpackages/create/src/frameworks/react/add-ons/clerk/assets/src/integrations/clerk/provider.tsxpackages/create/src/frameworks/react/add-ons/clerk/assets/src/routes/demo/clerk.tsxpackages/create/src/frameworks/react/add-ons/clerk/info.jsonpackages/create/src/frameworks/react/add-ons/clerk/package.jsonpackages/create/src/frameworks/react/add-ons/sentry/assets/instrument.server.mjspackages/create/src/frameworks/react/add-ons/sentry/info.jsonpackages/create/src/frameworks/react/add-ons/sentry/package.jsonpackages/create/src/frameworks/react/add-ons/workos/README.mdpackages/create/src/frameworks/react/add-ons/workos/assets/_dot_env.local.appendpackages/create/src/frameworks/react/add-ons/workos/assets/src/components/workos-user.tsxpackages/create/src/frameworks/react/add-ons/workos/assets/src/hooks/useUser.tsxpackages/create/src/frameworks/react/add-ons/workos/assets/src/integrations/workos/provider.tsxpackages/create/src/frameworks/react/add-ons/workos/assets/src/routes/api/auth/callback.tsxpackages/create/src/frameworks/react/add-ons/workos/assets/src/routes/api/auth/sign-in.tsxpackages/create/src/frameworks/react/add-ons/workos/assets/src/routes/demo/workos.tsxpackages/create/src/frameworks/react/add-ons/workos/info.jsonpackages/create/src/frameworks/react/add-ons/workos/package.jsonpackages/create/src/frameworks/react/hosts/cloudflare/package.json.ejspackages/create/src/frameworks/react/hosts/nitro/package.jsonpackages/create/src/frameworks/react/hosts/railway/README.mdpackages/create/src/frameworks/react/hosts/railway/assets/nixpacks.tomlpackages/create/src/frameworks/react/hosts/railway/info.jsonpackages/create/src/frameworks/react/hosts/railway/package.jsonpackages/create/src/frameworks/react/hosts/railway/package.json.ejspackages/create/src/frameworks/react/project/base/pnpm-workspace.yaml.ejspackages/create/src/frameworks/react/project/base/src/start.ts.ejspackages/create/src/frameworks/solid/add-ons/sentry/package.jsonpackages/create/src/frameworks/solid/hosts/cloudflare/package.json.ejspackages/create/src/frameworks/solid/hosts/nitro/package.jsonpackages/create/src/frameworks/solid/hosts/railway/README.mdpackages/create/src/frameworks/solid/hosts/railway/assets/nixpacks.tomlpackages/create/src/frameworks/solid/hosts/railway/info.jsonpackages/create/src/frameworks/solid/hosts/railway/package.jsonpackages/create/src/frameworks/solid/project/base/pnpm-workspace.yaml.ejspackages/create/src/types.tspackages/create/tests/add-to-app.test.tspackages/create/tests/config-file.test.tspackages/create/tests/edge-manifest.test.tspackages/create/tests/partner-addons.test.ts
💤 Files with no reviewable changes (4)
- packages/create/src/frameworks/react/hosts/railway/package.json
- packages/create/src/frameworks/react/hosts/railway/assets/nixpacks.toml
- packages/create/src/frameworks/react/add-ons/workos/assets/src/hooks/useUser.tsx
- packages/create/src/frameworks/solid/hosts/railway/assets/nixpacks.toml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Validation:
This supersedes the overlapping implementation work in #408 and #485.
Summary by CodeRabbit
.env*values when updating generated projects.