Skip to content

Improve maintainer skill-authoring DX#190

Merged
LadyBluenotes merged 4 commits into
mainfrom
pre-m2/maintainer-dx
Jul 2, 2026
Merged

Improve maintainer skill-authoring DX#190
LadyBluenotes merged 4 commits into
mainfrom
pre-m2/maintainer-dx

Conversation

@LadyBluenotes

Copy link
Copy Markdown
Member

Summary

Offline-first fixes to the maintainer skill authoring and update loop — the friction around actually updating a shipped skill.

  • Add validate --set-version <version> (5ebd44a) — updating the library version a skill targets meant hand-editing metadata.library_version across every SKILL.md, which is tedious and error-prone in a package with many skills. The new verb stamps the version across all matched skills and then re-validates. It reuses validate's existing file discovery and YAML-frontmatter surgery, so comments, CRLF line endings, and body bytes are preserved (no naive find/replace). Adds the key when absent, overwrites when present, and is idempotent. Guards reject --set-version --check and an empty/whitespace value; files whose metadata is a non-mapping scalar are skipped (validation already errors on those).
  • Align the generate-skill meta-skill with the validator (0e4668f) — the generator instructed agents that the full slash path (e.g. tanstack-query/core) was the frontmatter name, but validate rejects any name containing / and requires it to equal the parent directory. Corrected the input definition, the three frontmatter template blocks, and the validation checklist so generated skills validate on the first pass. Docs-only.
  • Point the skill-staleness-check meta-skill at the real command (0696d3f) — it referenced a scripts/sync-skills.mjs that does not exist in the repo. Rewritten to use the real intent stale command and to describe the actual sync-state.json shape. Docs-only.

Impact / compatibility

  • --set-version is maintainer/author-side release plumbing (local or CI postversion), never a runtime or consumer concern. It changes only the version stamp, not skill content.
  • The version is passed explicitly — the command does not read the package version automatically.
  • The two meta-skill changes are documentation-only; no code paths or generated skill layouts change.

@nx-cloud

nx-cloud Bot commented Jul 2, 2026

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit c5af4f0

Command Status Duration Result
nx run-many --targets=build --exclude=examples/** ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2026-07-02 17:56:12 UTC

@pkg-pr-new

pkg-pr-new Bot commented Jul 2, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/TanStack/intent/@tanstack/intent@190

commit: c5af4f0

@coderabbitai

coderabbitai Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Caution

Review failed

An error occurred during the review process. Please try again later.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch pre-m2/maintainer-dx

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai

coderabbitai Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The head commit changed during the review from 0e4668f to c5af4f0.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch pre-m2/maintainer-dx

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@LadyBluenotes LadyBluenotes merged commit 45c863d into main Jul 2, 2026
9 checks passed
@LadyBluenotes LadyBluenotes deleted the pre-m2/maintainer-dx branch July 2, 2026 18:01
@github-actions github-actions Bot mentioned this pull request Jul 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant