Repository navigation
Conversation
…s queries still fetch fetchOptimistic builds the query from the observer's options but then calls query.fetch() without them. QueryCache.build returns an existing query without applying options, so a query that was rebuilt without a queryFn - by broadcastQueryClient from a cross-tab message, or hydrated - throws Missing queryFn when a suspending observer fetches it before any observer has attached: the fallback at the top of fetch() only looks at already-attached observers, and there are none yet in this path. Reported through query-broadcast-client-experimental: when a query is removed and re-added cross-tab, the rebuilt query stays without a queryFn if the other tab's fetch never succeeds, and a mounted useSuspenseQuery crashes with Missing queryFn on its next optimistic fetch instead of fetching with its own options. The regression test reproduces that sequence: observer bound -> query removed -> rebuilt from key+hash only -> fetchOptimistic. It fails with Missing queryFn before this change and succeeds after. Full queryObserver suite (76) and broadcast client suite (13) pass. Fixes TanStack#12129
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Description check |  |
The description clearly explains the bug, affected scenarios, implementation, regression test, test results, and linked issue. However, it omits the required Checklist and Release Impact sections, inc… | Add the required Checklist and Release Impact sections. Mark each checklist item accurately, state whether a changeset was generated, and identify this as a published-code change or docs/CI/dev-only change. |
-
Check name Status Explanation Title check The title is concise, specific, and accurately describes the main change: passing options to fetchOptimistic so queries without a queryFn can still fetch. Linked Issues check Issue [ #12129] requires an already mounted suspending observer to fetch a rebuilt query with the observer's ownqueryFn.QueryObserver.fetchOptimisticnow callsquery.fetch(defaultedOptions). Th…Out of Scope Changes check The pull request changes only QueryObserver.fetchOptimisticand adds its focused regression test. Both changes directly support issue [#12129]. No unrelated behavior or files are changed.Docstring Coverage No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2… Full details: Linked Issues check
-
Explanation
Issue [
#12129] requires an already mounted suspending observer to fetch a rebuilt query with the observer's ownqueryFn.QueryObserver.fetchOptimisticnow callsquery.fetch(defaultedOptions). The added regression test removes the original query, rebuilds it without aqueryFn, and verifies that the fetch returnsdatafrom the supplied function. This implements the linked issue's requested fix.
Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2 files.
-
Full details: Description check
-
Explanation
The description clearly explains the bug, affected scenarios, implementation, regression test, test results, and linked issue. However, it omits the required Checklist and Release Impact sections, including the changeset declaration for a published-code change.
Resolution
Add the required Checklist and Release Impact sections. Mark each checklist item accurately, state whether a changeset was generated, and identify this as a published-code change or docs/CI/dev-only change.
- Fix all pre-merge checks with AI
✨ Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
2 participants
fetchOptimisticbuilds the query from the observer's defaulted options but then callsquery.fetch()without them. SinceQueryCache.buildreturns an existing query without applying options, a query that already exists without aqueryFnthrowsMissing queryFnhere: the fallback at the top offetch()only looks at already-attached observers, and in this path none are attached yet - a suspending observer is still bound to the previous query object and only re-binds in a later effect.This is reachable through
broadcastQueryClient(reported in #12129): a query removed in one tab is rebuilt in the other from{ queryKey, queryHash }only; if the other tab's fetch never succeeds, no data-bearing update follows, and a mounteduseSuspenseQueryfor that key crashes withMissing queryFninstead of fetching with its own options. Hydrated andsetQueryData-created queries hit the same window.The fix passes the defaulted options to
fetch(), whosesetOptionssupplies the queryFn. In the normal path this is a no-op (the freshly built query was constructed with exactly these options).Regression test reproduces the reported sequence (observer bound -> query removed -> rebuilt from key+hash only ->
fetchOptimistic): fails withMissing queryFnbefore, succeeds after. FullqueryObserversuite (76/76) andquery-broadcast-client-experimentalsuite (13/13) pass.Fixes #12129
Summary by CodeRabbit