refactor(maintainers): size card grids by container width instead of viewport - #1169
refactor(maintainers): size card grids by container width instead of viewport#1169sukvvon wants to merge 5 commits into
Conversation
…o card width with container query
…nd adjust responsive columns
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (3)
Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review. 📝 WalkthroughWalkthroughThe changes update maintainer, contributor, and instructor layouts to use container queries, auto-fit columns, revised breakpoints, unconstrained child widths, and responsive page spacing. ChangesResponsive card layouts
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This PR adjusts maintainer card grid sizing and responsive breakpoints without introducing a concrete correctness, security, availability, or deployment risk; no actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
tanstack-com | da5b37f | Commit Preview URL Branch Preview URL |
Aug 18 2026, 07:08 PM |
Maintainer card grids sized their columns from the viewport while the cards themselves were capped at a fixed width, so the two disagreed: cards stopped growing while their grid tracks kept expanding, and the leftover space turned into gaps. Narrow screens also dropped to a single column, turning a 40-person list into a very long scroll.
Affected pages
Every place
MaintainerCardrenders in its full variant. Preview: https://refactor-maintainer-card-responsive-grid-tanstack-com.thetanstack.workers.dev/maintainersauto-fitgrid, container-based 3-column ceiling, tighter vertical rhythm/paid-supportauto-fitgrid, container-based 3-column ceiling/query/latest/docs/contributorsauto-fitgrid, container-based 3-column ceiling/sm:grid-cols-3step, released card cap, synced skeleton/workshopslg→md, released card capThe contributors page applies to every library, not just Query.
MaintainersSection/LandingCommunitySectionuse the same grid but are unreachable — nothing importsLandingCommunitySection— so they are left untouched.Changes
MaintainerCard— the name switched fromsm:text-ds-mono-lg(viewport) to@[13rem]:text-ds-mono-lg(card width). The card is now an@container, so the name follows the space it actually has rather than the window size.Grids —
maintainers,paid-support, and the librarycontributorspage replacegrid-cols-1 sm:grid-cols-2 lg:grid-cols-3withgrid-cols-2as a floor, anauto-fittrack above@[28rem](minmax(180px,1fr)), and a 3-column ceiling at@[43rem].[&>*>*]:max-w-nonereleases the card cap so cards fill their track.Both bounds are per-container, not per-viewport. That matters on the contributors page, where the partners sidebar leaves the content column far narrower than the window — a viewport breakpoint forced 3 columns into a 380px area.
The two-column floor replaces the old single-column step. On a 375px screen a 40-person list goes from roughly 18,600px of scroll to 5,640px (~70% less) while the avatar stays at 148px, which is still large enough to recognize a face.
Home — added
sm:grid-cols-3between the existing 2- and 5-column steps, and matched the loading skeleton so the layout does not shift when content arrives.Workshops — moved the 4-column step from
lgtomd. With 4 instructors this keeps rows balanced (2+2 or 4) and avoids the 2-column stretch that let cards reach ~484px.Also reduced the vertical rhythm on
maintainersfor narrow screens (gap-16→gap-6 md:gap-16,gap-12→gap-6 md:gap-12,mt-4→mt-3 md:mt-4).Verification
Measured in the browser across container widths on every affected page:
paid-support, 70px on home/workshops)compactandrowview modes unaffected; light mode unchangedSummary by CodeRabbit