Skip to content

Remove unused component props and optional arguments #1173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JonasBa wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Remove unused component props and optional arguments #1173

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ac9b979
Remove unused public component props that nothing provided.
Aug 20, 2026
7231523
Remove unused optional arguments and fields that nothing provided.
Aug 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 1 addition & 11 deletions src/auth/oauth.server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,23 +269,13 @@ export async function exchangeGitHubCode(
code: string,
clientId: string,
clientSecret: string,
redirectUri?: string,
): Promise<GitHubTokenResult> {
const body: {
client_id: string
client_secret: string
code: string
redirect_uri?: string
} = {
const body = {
client_id: clientId,
client_secret: clientSecret,
code,
}

if (redirectUri) {
body.redirect_uri = redirectUri
}

const tokenResponse = await fetch(
'https://github.com/login/oauth/access_token',
{
Expand Down
5 changes: 1 addition & 4 deletions src/builder/api/create-worker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,9 +123,7 @@ type GeneratedAddOnMetadata = Omit<
| 'partner'
| 'packageAdditions'
> &
GeneratedAddOnFields & {
packageAdditions?: GeneratedAddOnPackageAdditions
}
GeneratedAddOnFields

type GeneratedWorkerAddOnManifestModule = GeneratedWorkerManifestModule & {
addOn: GeneratedAddOnManifest
Expand Down Expand Up @@ -365,7 +363,6 @@ function getAddOnMetadata(
envVars: getAddOnEnvVars(addOn.envVars),
options: getAddOnOptions(addOn.options),
partner: getAddOnPartner(addOn.partner),
packageAdditions: getPackageAdditions(addOn.packageAdditions),
}
}

Expand Down
3 changes: 0 additions & 3 deletions src/builder/api/feature-artifacts.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import { type AddOnCompiled } from './compile'
import { compileWithAttributionHandler, type ProjectDefinition } from './compile'
import { type FrameworkId } from './config'

Expand All @@ -8,7 +7,6 @@ export interface FeatureArtifactsRequest {
framework?: FrameworkId
tailwind?: boolean
featureOptions?: Record<string, Record<string, unknown>>
customIntegrations?: Array<AddOnCompiled>
}

export interface FeatureArtifact {
Expand Down Expand Up @@ -44,7 +42,6 @@ export async function featureArtifactsHandler(
tailwind,
features: request.features,
featureOptions: request.featureOptions ?? {},
customIntegrations: request.customIntegrations,
}

const output = await compileWithAttributionHandler(definition)
Expand Down
Loading