Skip to content

sorts: make cycle_sort generic for comparable items - #15329

Merged
cclauss merged 1 commit into
TheAlgorithms:masterfrom
Rayan-and-beyond:fix/cycle-sort-comparable
Sep 18, 2026
Merged

cclauss merged 1 commit into
TheAlgorithms:masterfrom
Rayan-and-beyond:fix/cycle-sort-comparable

Conversation

@Rayan-and-beyond

Copy link
Copy Markdown
Contributor

Describe your change

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Make cycle_sort() generic over comparable element types while preserving its in-place behavior and return element type.

Add doctests for strings and non-comparable mixed values, and include cycle_sort in the shared TypeError regression test. The shared comparison-sort suite already exercises floats, strings, dataclasses, and named tuples for this algorithm.

Part of #15234

Checklist

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues, then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper Bot added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files labels Sep 14, 2026
@algorithms-keeper algorithms-keeper Bot removed the awaiting reviews This PR is ready to be reviewed label Sep 18, 2026
@cclauss
cclauss merged commit 092b9d0 into TheAlgorithms:master Sep 18, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement This PR modified some existing files on hold

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants