Fix out-of-range recursion in interpolation_search_by_recursion - #15333
Open
RizgarOzan wants to merge 1 commit into
Open
RizgarOzan wants to merge 1 commit into
RizgarOzan wants to merge 1 commit into
Conversation
Member
|
ON HOLD: Our focus is on merging or closing old pull requests before October 1st. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change
interpolation_search_by_recursionnever checks thatleft <= right(the iterativeinterpolation_searchdoes, via itswhileloop), so an item just above the last element, an empty list, or a range reversed by thepoint > rightbranch crashes instead of returningNone:This adds the missing bounds guard. The equal-ends branch is collapsed into a single
returnto stay within ruff's PLR0911 limit. New doctests cover the three crashing cases plus the symmetric below-minimum case; they fail onmaster(3 failures) and pass with the fix (python -m doctest -v: 21 passed). A 200k-case random comparison against a brute-force search now passes for both functions.ruff check,ruff format --check,ty checkand pre-commit on the file are clean.Checklist