Skip to content

Default OPDS2+ODL skipped_license_formats to empty (PP-4044)#3276

Merged
jonathangreen merged 2 commits intomainfrom
feature/odl-default-skipped-license-formats
Apr 22, 2026
Merged

Default OPDS2+ODL skipped_license_formats to empty (PP-4044)#3276
jonathangreen merged 2 commits intomainfrom
feature/odl-default-skipped-license-formats

Conversation

@jonathangreen
Copy link
Copy Markdown
Member

Description

Change the default value of OPDS2WithODLSettings.skipped_license_formats from ["text/html"] to []. ODL 2.0 integrations will no longer suppress the text/html license format by default, which means the streaming delivery mechanism (STREAMING_DRM) will be emitted for those titles.

Motivation and Context

PP-4044. We want streaming web-reader delivery to be active by default for ODL integrations.

A production audit of the integration_configurations.settings JSONB column across our environments confirmed that every existing ODL 2.0 row either omits skipped_license_formats or already stores [] — none store the previous ["text/html"] default explicitly. Rows that omit the key will pick up the new default and start emitting streaming formats; that behavior change is the goal, and because nothing stores the old default explicitly we don't need a data migration to clear it out.

How Has This Been Tested?

Existing extractor tests in tests/manager/integration/license/opds/odl/test_extractor.py continue to cover the explicit-skip path. The change is a single default-value flip; behavior under explicit configuration is unchanged.

Checklist

  • I have updated the documentation accordingly.
  • All new and existing tests passed.

Previously new ODL 2.0 integrations defaulted to skipping the
"text/html" license format, which suppressed the streaming
delivery mechanism. Production audit shows existing rows either
omit the setting or already store an empty list, so flipping the
default doesn't require a data migration.
@jonathangreen jonathangreen added the feature New feature label Apr 21, 2026
@claude
Copy link
Copy Markdown
Contributor

claude Bot commented Apr 21, 2026

Claude finished @jonathangreen's task in 1m 10s —— View job


Review

  • Gather context
  • Read changed files
  • Analyze changes
  • Post review

The change is minimal, correct, and well-motivated. Flipping skipped_license_formats from ["text/html"] to [] is a single-line settings default change with cleanly updated tests. The extractor tests still cover all four explicit-skip cases (feedbooks audio, streaming audio via text/html, streaming text via text/html, and raw text/html skipping), so the skip path remains well-tested. The production audit described in the PR description removes any concern about existing rows needing a data migration. No issues found.

@jonathangreen jonathangreen requested a review from a team April 21, 2026 17:02
The OPDS2+ODL fixtures feed.json and feed-audiobook-streaming.json
both declare a text/html license format. With the new default
empty skipped_license_formats, these now produce an additional
streaming delivery mechanism alongside the existing ones.
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.31%. Comparing base (45176e0) to head (7c9e2c0).
⚠️ Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3276      +/-   ##
==========================================
- Coverage   93.31%   93.31%   -0.01%     
==========================================
  Files         502      502              
  Lines       46178    46178              
  Branches     6315     6315              
==========================================
- Hits        43093    43091       -2     
- Misses       2001     2002       +1     
- Partials     1084     1085       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@tdilauro tdilauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔧 🚀

@jonathangreen jonathangreen merged commit b510257 into main Apr 22, 2026
21 checks passed
@jonathangreen jonathangreen deleted the feature/odl-default-skipped-license-formats branch April 22, 2026 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants