feat: add nullable to model config params#2452
Merged
rsynek merged 6 commits intoJul 8, 2026
Merged
Conversation
diogodanielsoaresferreira
temporarily deployed
to
internal
GitHub Actions
Inactive
diogodanielsoaresferreira
temporarily deployed
to
internal
GitHub Actions
Inactive
cristianonicolai
approved these changes
Jul 2, 2026
mswiderski
approved these changes
Jul 2, 2026
mswiderski
left a comment
mswiderski
left a comment
Contributor
There was a problem hiding this comment.
approving as this is valid for the OpenAPI version used by models
diogodanielsoaresferreira
temporarily deployed
to
internal
GitHub Actions
Inactive
diogodanielsoaresferreira
temporarily deployed
to
internal
GitHub Actions
Inactive
rsynek
approved these changes
Jul 7, 2026
rsynek
force-pushed
the
add_nullable_to_model_config_param
branch
from
5de80d6 to
946ac47
Compare
Contributor
|
LGTM; let's wait for the CI to finish, as there were some failures related to the changes. |
Contributor
|
ai.timefold.solver.service.quarkus.deployment.ModelConfigDescriptorSchemaTest.detectModelConfigOverrides keeps failing. @diogodanielsoaresferreira could you please have a look? |
…danielsoaresferreira/timefold-solver into add_nullable_to_model_config_param
diogodanielsoaresferreira
temporarily deployed
to
internal
GitHub Actions
Inactive
diogodanielsoaresferreira
temporarily deployed
to
internal
GitHub Actions
Inactive
|
Contributor
Author
@rsynek should be fixed, the current error in ESS seems unrelated. |
rsynek
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: https://github.com/TimefoldAI/timefold-platform/issues/4992