ci: make version update idempotent#2482
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes the CI “version update” step idempotent by removing the Maven versions:set invocation and directly rewriting the <revision> property in the two POMs that define it.
Changes:
- Remove
./mvnw versions:set ...from the version-change script. - Update the root
pom.xmlandservice/facade/service-parent/pom.xml<revision>values viased.
Comment on lines
6
to
8
| echo " New version: $NEW_VERSION" | ||
| ./mvnw versions:set -Dfull -Dproperty=revision -DnewVersion="$NEW_VERSION" -Drevision="$NEW_VERSION" -DgenerateBackupPoms=false | ||
| # replaces the parent revision which is not updated by the previous command | ||
| sed -i "0,/<\/revision>/s/<revision>.*<\/revision>/<revision>$NEW_VERSION<\/revision>/" pom.xml | ||
| sed -i "0,/<\/revision>/s/<revision>.*<\/revision>/<revision>$NEW_VERSION<\/revision>/" service/facade/service-parent/pom.xml |
triceo
approved these changes
Jul 10, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.