-
-
Notifications
You must be signed in to change notification settings - Fork 108
Basic Bot Analytics System #1425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
firasrg
wants to merge
6
commits into
develop
Choose a base branch
from
firasrg/analytics
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+106
−17
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
8774945
Analytics service setup with first use in Ping command
firasrg 5002f75
Analytics: remove AnalyticsService injection in PingCommand and using…
firasrg 071c1dc
feat: update command usage analytics to use generated record methods
firasrg 25a4407
Analytics: applies changes for zabuzard 1st CR;
firasrg a27f89e
Analytics - Metrics > persist(): rename argument moment to happenedAt
firasrg 75618d5
Analytics update
firasrg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
56 changes: 56 additions & 0 deletions
56
application/src/main/java/org/togetherjava/tjbot/features/analytics/Metrics.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| package org.togetherjava.tjbot.features.analytics; | ||
|
|
||
| import org.slf4j.Logger; | ||
| import org.slf4j.LoggerFactory; | ||
|
|
||
| import org.togetherjava.tjbot.db.Database; | ||
| import org.togetherjava.tjbot.db.generated.tables.MetricEvents; | ||
|
|
||
| import java.time.Instant; | ||
| import java.util.concurrent.ExecutorService; | ||
| import java.util.concurrent.Executors; | ||
|
|
||
| /** | ||
| * Service for tracking and recording events for analytics purposes. | ||
| */ | ||
| public final class Metrics { | ||
| private static final Logger logger = LoggerFactory.getLogger(Metrics.class); | ||
|
|
||
| private final Database database; | ||
|
|
||
| private final ExecutorService service = Executors.newSingleThreadExecutor(); | ||
|
|
||
| /** | ||
| * Creates a new instance. | ||
| * | ||
| * @param database the database to use for storing and retrieving analytics data | ||
| */ | ||
| public Metrics(Database database) { | ||
| this.database = database; | ||
| } | ||
|
|
||
| /** | ||
| * Track an event execution. | ||
| * | ||
| * @param event the event to save | ||
| */ | ||
| public void count(String event) { | ||
| logger.debug("Counting new record for event: {}", event); | ||
| Instant moment = Instant.now(); | ||
| service.submit(() -> processEvent(event, moment)); | ||
|
|
||
| } | ||
|
|
||
| /** | ||
| * | ||
| * @param event the event to save | ||
| * @param happenedAt the moment when the event is dispatched | ||
| */ | ||
| private void processEvent(String event, Instant happenedAt) { | ||
| database.write(context -> context.newRecord(MetricEvents.METRIC_EVENTS) | ||
| .setEvent(event) | ||
| .setHappenedAt(happenedAt) | ||
| .insert()); | ||
| } | ||
|
|
||
| } |
13 changes: 13 additions & 0 deletions
13
application/src/main/java/org/togetherjava/tjbot/features/analytics/package-info.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| /** | ||
| * Analytics system for collecting and persisting bot activity metrics. | ||
| * <p> | ||
| * This package provides services and components that record events for later analysis and reporting | ||
| * across multiple feature areas. | ||
| */ | ||
| @MethodsReturnNonnullByDefault | ||
| @ParametersAreNonnullByDefault | ||
| package org.togetherjava.tjbot.features.analytics; | ||
|
|
||
| import org.togetherjava.tjbot.annotations.MethodsReturnNonnullByDefault; | ||
|
|
||
| import javax.annotation.ParametersAreNonnullByDefault; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 6 additions & 0 deletions
6
application/src/main/resources/db/V16__Add_Analytics_System.sql
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| CREATE TABLE metric_events | ||
| ( | ||
| id INTEGER PRIMARY KEY AUTOINCREMENT, | ||
| event TEXT NOT NULL, | ||
| happened_at TIMESTAMP NOT NULL | ||
| ); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.