Skip to content

chore(helm): name values cases by the org naming convention - #64

Merged
yordis merged 1 commit into
mainfrom
yordis/chore-helm-values-cases
Oct 11, 2026
Merged

yordis merged 1 commit into
mainfrom
yordis/chore-helm-values-cases

Conversation

@yordis

@yordis yordis commented Oct 11, 2026 •

Copy link
Copy Markdown
Member
  • One naming rule should cover every values case in every chart, instead of a tool-specific ci/ exception that only chart-testing recognizes (straw-hat-team ADR 2078011537)
  • Keeping cases at the chart root under values..yaml makes them discoverable the same way defaults are, without a reader needing to know chart-testing's hardcoded glob
  • The helm-lint and kubeconform mise tasks already loop over every case for every chart on each push, so dropping the ci/ convention does not cost any coverage ct lint provided

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

A single naming rule for every values case, defaults in values.yaml
and every other case as values.<case>.yaml at the chart root, beats a
tool-specific ci/ exception that only chart-testing recognizes
(ADR 2078011537).

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@cursor

cursor Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

PR Summary

Low Risk
CI tooling and Helm chart packaging/version bumps only; no runtime application logic changes.

Overview
Helm values cases now follow a single org convention: per-chart overrides live at the chart root as values.<case>.yaml instead of chart-testing’s ci/*-values.yaml layout.

The helm-lint and kubeconform mise tasks were updated to lint/template against values.*.yaml, so every case still gets exercised on push without relying on chart-testing’s special path. trogon-atlas, trogon-atlas-server, and trogon-atlas-studio chart versions were bumped to 0.1.2, with the umbrella chart’s local subchart dependencies pinned to the same version.

Reviewed by Cursor Bugbot for commit f759d8b. Bugbot is set up for automated code reviews on this repo. Configure here.

@coderabbitai

coderabbitai Bot commented Oct 11, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 58 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 7c0d3cf9-01b6-49b3-a2c6-4fd0d3650cd0

📥 Commits

Reviewing files that changed from the base of the PR and between e02d43f and f759d8b.


📒 Files selected for processing (9)
  • .config/mise/tasks/github/workflows/infra/helm-lint
  • .config/mise/tasks/github/workflows/infra/kubeconform
  • devops/helm/charts/trogon-atlas-server/Chart.yaml
  • devops/helm/charts/trogon-atlas-server/values.anonymous.yaml
  • devops/helm/charts/trogon-atlas-server/values.full.yaml
  • devops/helm/charts/trogon-atlas-studio/Chart.yaml
  • devops/helm/charts/trogon-atlas-studio/values.token.yaml
  • devops/helm/charts/trogon-atlas/Chart.yaml
  • devops/helm/charts/trogon-atlas/values.anonymous.yaml

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@yordis
yordis merged commit 376f2b8 into main Oct 11, 2026
34 checks passed
@yordis
yordis deleted the yordis/chore-helm-values-cases branch October 11, 2026 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant