Move turf.min.js builds to esbuild#3076
Draft
mfedderly wants to merge 1 commit into
Draft
Conversation
This drops rollup and babel and gives us a single modern bundler to keep up to date. The target for esbuild was taken from browserslist's 'default' setting as of 2026-06-21 and then changed to the esbuild syntax. Babel and rollup keep hitting us with CVEs and have large npm ecosystem dependency trees. Esbuild has intentionally restricted themselves to only taking an additional dependency on a single set of APIs from Google themselves. In the event of an esbuild vulnerability the difficulty of an update should be limited. Currently we're having issues updating rollup to remove vulnerability warnings because it changes the output and it fails our own es5 checks for turf.min.js.
Collaborator
Author
|
I'm curious for feedback on this if anyone else has a bundling tool that should be considered alongside esbuild. This was pretty easy to create (which makes me happy, but also makes it easy to throw away if another bundler is better). (Some of the) Factors I'm considering when judging bundlers:
|
Collaborator
Author
|
Note that this PR does not deduplicate the eslint version with tsup (which I'd like to remove, which will fix the dependency situation), and babel is still transitively required through |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This drops rollup and babel and gives us a single modern bundler to keep up to date. The target for esbuild was taken from browserslist's 'default' setting as of 2026-06-21 and then changed to the esbuild syntax.
Babel and rollup keep hitting us with CVEs and have large npm ecosystem dependency trees. Esbuild has intentionally restricted themselves to only taking an additional dependency on a single set of APIs from Google themselves. In the event of an esbuild vulnerability the difficulty of an update should be limited. Currently we're having issues updating rollup to remove vulnerability warnings because it changes the output and it fails our own es5 checks for turf.min.js.