Record the Dependabot PR (checkout + URL) during PLANNING - #374
Merged
Conversation
For a github-dependabot task the PR is an input, not an output: the task memo IS the PR URL, and evaluating the bump is far stronger against the actual upgraded tree (resolved lockfile, transitive deps, a build/test spot-check) than against a remote diff. Move both concerns from ITERATING to PLANNING: - Gate `url-recorded` on PLANNING (the URL is the memo — a known input). - Reframe `checkout-dependabot-pr` as the PLANNING setup step: provision first (origin -> forge), `gh pr checkout`, then `set_url`. It stays a single workflow-wide skill, so ITERATING can re-run it defensively if a fresh container starts there. - PLANNING evaluates against the checked-out tree; ITERATING is purely implement-supporting-changes + push. The sibling github-self-reviewed / github-peer-reviewed workflows keep `url-recorded` on ITERATING (their PR is genuinely created there by `open-pr`). No core/service/schema changes. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
For a
github-dependabottask the PR is an input, not an output: the task memo is the PR URL, and evaluating a dependency bump is far stronger against the actual upgraded tree (resolved lockfile, new transitive deps, a build/test spot-check) than against a remotegh pr diff. So both the PR URL and the checkout belong to PLANNING, not ITERATING.This moves both concerns earlier in
github_dependabot.py:url-recordedis gated on PLANNING (the URL is the memo — a known input), and drops off ITERATING.checkout-dependabot-pris reframed as the PLANNING setup step: provision first (sooriginpoints at the forge),gh pr checkoutthe PR head, thenset_url. It stays a single workflow-wide skill, so ITERATING can re-run it defensively if a fresh container starts there.The sibling
github-self-reviewed/github-peer-reviewedworkflows are unchanged — their PR is genuinely created during ITERATING byopen-pr, sourl-recordedrightly stays there. Nocore/taskservice/sessionservice/ schema changes; this is declarative workflow config.Golden-spec tests in
tests/workflows/test_github_dependabot.pyare updated to match the moved gate.