Attach new artifacts through a running task's artifact modal - #376
Open
tildesrc wants to merge 1 commit into
Open
Attach new artifacts through a running task's artifact modal#376tildesrc wants to merge 1 commit into
tildesrc wants to merge 1 commit into
Conversation
Add a `ctrl+a` binding to the running-task artifact modal that opens the same file-picker used by the task-creation attach flow, then uploads each queued file to the task via `put_artifact`. The modal now opens even when the task has no artifacts yet, so attach is always reachable. DRY: reuses `ArtifactsScreen` (the picker) and `_artifact_path_candidates` wholesale — the only new code is the wiring and the per-file upload, which targets an existing task's REST artifacts rather than the create-task seed. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds the ability to attach new artifacts to a running task, reached from that task's artifact modal (the
akey on the dashboard).ArtifactScreen),ctrl+anow opens the file-picker and uploads the queued files to the task.aon an empty task just warned and opened nothing).DRY with task creation
The picker is
ArtifactsScreen— the same modal the task-creation memo uses for itsctrl+aattach — reused wholesale, along with_artifact_path_candidates(shell-quoted-path parsing),validate_segment, and the raw-bytes read. The only new code is the wiring plus a small per-file upload helper (Dashboard._attach_artifacts) that targets an existing task's REST artifacts viaput_artifact, rather than the create-task seed. Follows the existing "modal returns an intent, Dashboard does the I/O" pattern (mirrors the modal'srest/localmodes) — the viewer dismisses with a newattachmode and the Dashboard opens the picker and uploads.Binary files (screenshots) attach byte-for-byte via the raw-bytes
put_artifact; no server, REST, or MCP changes were needed.🤖 Generated with Claude Code