Auto-approve the Dependabot PR in MERGING (gated pr-approved responsibility) - #377
Open
tildesrc wants to merge 2 commits into
Open
Auto-approve the Dependabot PR in MERGING (gated pr-approved responsibility)#377tildesrc wants to merge 2 commits into
tildesrc wants to merge 2 commits into
Conversation
The github-dependabot lifecycle now approves the bump PR while shepherding the merge, satisfying branch protection's required-review gate so the bump lands through the merge queue without a human clicking Approve. Dependabot authored the PR, so the agent's token is a different identity and may approve it. This is scoped to github-dependabot only: on the self/peer- reviewed lifecycles the agent is effectively the PR author and must not self- approve. The shared babysit-merge skill gains a small overridable _merge_approval_step() seam (empty by default, leaving self/peer-reviewed byte-for-byte unchanged); GithubDependabot overrides it to splice `gh pr review --approve` in just before the PR is queued. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Reworks the auto-approval into a dependabot-only gated step instead of a clause spliced into the shared babysit-merge skill: - MERGING gains a `pr-approved` responsibility, so approval is an explicit, dashboard-visible promise the agent must resolve before COMPLETE — not a line of prose it could skim past. - A new `approve-dependabot-pr` skill approves the bump PR (`gh pr review --approve`) at the start of MERGING, then resolves the gate and hands off to babysit-merge. - The shared `babysit-merge` / `github_forge.py` are reverted to unchanged, so the self/peer-reviewed lifecycles are untouched and there is no fork. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
tildesrc
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The
github-dependabotworkflow now approves the Dependabot bump PR during its MERGING step, so branch protection's required-approving-review gate is satisfied and the bump can land without a human clicking Approve.Approval is modeled as an explicit, gated step, not a buried instruction:
pr-approvedresponsibility — a dashboard-visible promise the agent must resolve before it can advance to COMPLETE.approve-dependabot-prskill runs at the start of MERGING:gh pr review <url> --approve, then resolvespr-approvedand hands off tobabysit-mergeto shepherd the merge.Why this is scoped to github-dependabot
Dependabot authors the PR, so the agent runs under a different identity (the repo's
GH_TOKEN) and is permitted to approve it. On the self-reviewed / peer-reviewed lifecycles the agent is effectively the PR author and must not self-approve — so this behavior is deliberately limited togithub-dependabot.Design
The merge machinery stays shared and unchanged:
babysit-mergeandgithub_forge.pyare untouched (no fork, no drift). Approval is a separate skill + gated responsibility owned entirely byGithubDependabot. Because the human already self-reviews the bump in ITERATING before advancing to MERGING, this gate reflects that task-level approval onto GitHub.Tests
babysit-ciandbabysit-mergeare still asserted reused verbatim from the forge base.pr-approvedandpr-merged.approve-dependabot-prskill approves the PR, resolves thepr-approvedgate, and hands off tobabysit-merge.