Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion analysis_options.yaml
Original file line number Diff line number Diff line change
@@ -1 +1 @@
include: package:very_good_analysis/analysis_options.6.0.0.yaml
include: package:very_good_analysis/analysis_options.7.0.0.yaml
2 changes: 1 addition & 1 deletion example/analysis_options.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
include: package:very_good_analysis/analysis_options.6.0.0.yaml
include: package:very_good_analysis/analysis_options.7.0.0.yaml
linter:
rules:
public_member_api_docs: false
2 changes: 1 addition & 1 deletion example/lib/example.dart
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,4 @@
/// # see usage
/// example_cli --help
/// ```
library example;
library;
2 changes: 1 addition & 1 deletion example/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ dependencies:
dev_dependencies:
mocktail: ^1.0.4
test: ^1.25.8
very_good_analysis: ^6.0.0
very_good_analysis: ^7.0.0

executables:
example_cli:
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@Tags(['integration'])
library integration_tests;
library;

import 'package:test/test.dart';

Expand Down
2 changes: 1 addition & 1 deletion lib/cli_completion.dart
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/// Contains the completion command runner based elements to add completion to
/// dart command line applications.
library cli_completion;
library;

export 'src/command_runner/commands/commands.dart';
export 'src/command_runner/completion_command_runner.dart';
2 changes: 1 addition & 1 deletion lib/installer.dart
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/// Contains the functions related to the installation process
/// {@canonicalFor system_shell.SystemShell}
library installer;
library;

export 'src/installer/installer.dart';
export 'src/system_shell.dart';
2 changes: 1 addition & 1 deletion lib/parser.dart
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/// Contains the classes and functions related to the creation of suggestions
/// for the completion of commands.
library parser;
library;

export 'src/parser/completion_level.dart';
export 'src/parser/completion_result.dart';
Expand Down
2 changes: 1 addition & 1 deletion lib/src/parser/arg_parser_extension.dart
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ extension ArgParserExtension on ArgParser {
while (currentArgs.isNotEmpty) {
try {
return loosenOptionsGramamar.parse(currentArgs);
} catch (_) {
} on Exception catch (_) {
currentArgs = currentArgs.take(currentArgs.length - 1).toList();
}
}
Expand Down
2 changes: 1 addition & 1 deletion pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,4 @@ dependencies:
dev_dependencies:
mocktail: ^1.0.4
test: ^1.25.8
very_good_analysis: ^6.0.0
very_good_analysis: ^7.0.0
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ class _TestCompletionCommandRunner extends CompletionCommandRunner<int> {
String get executableName => 'test_cli';

@override
// Override acceptable for test files
// ignore: overridden_fields
final Logger completionLogger = MockLogger();
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ class _TestCompletionCommandRunner extends CompletionCommandRunner<int> {
_TestCompletionCommandRunner() : super('test', 'Test command runner');

@override
// Override acceptable for test files
// ignore: overridden_fields
final Logger completionInstallationLogger = _MockLogger();

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ class _TestCompletionCommandRunner extends CompletionCommandRunner<int> {
_TestCompletionCommandRunner() : super('test', 'Test command runner');

@override
// Override acceptable for test files
// ignore: overridden_fields
final Logger completionInstallationLogger = _MockLogger();

Expand Down
2 changes: 2 additions & 0 deletions test/src/command_runner/completion_command_runner_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,12 @@ class _TestCompletionCommandRunner extends CompletionCommandRunner<int> {
bool enableAutoInstall = true;

@override
// Override acceptable for test files
// ignore: overridden_fields
final Logger completionLogger = MockLogger();

@override
// Override acceptable for test files
// ignore: overridden_fields
final Logger completionInstallationLogger = MockLogger();

Expand Down
1 change: 1 addition & 0 deletions test/src/installer/completion_configuration_test.dart
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
// Not required for test files
// ignore_for_file: prefer_const_constructors

import 'dart:collection';
Expand Down
5 changes: 5 additions & 0 deletions test/src/installer/completion_installation_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -224,6 +224,7 @@ void main() {

expect(configFile.existsSync(), true);

// Different format needed for matching cli output
// ignore: leading_newlines_in_multiline_strings
expect(configFile.readAsStringSync(), '''
\n## [very_good]
Expand Down Expand Up @@ -285,6 +286,7 @@ void main() {

installation.writeToShellConfigFile('very_good');

// Different format needed for matching cli output
// ignore: leading_newlines_in_multiline_strings
expect(rcFile.readAsStringSync(), '''
\n## [Completion]
Expand Down Expand Up @@ -432,6 +434,7 @@ void main() {

// rc fle includes one reference to the global config

// Different format needed for matching cli output
// ignore: leading_newlines_in_multiline_strings
expect(rcFile.readAsStringSync(), '''
\n## [Completion]
Expand All @@ -446,6 +449,7 @@ void main() {
path.join(configDir.path, 'zsh-config.zsh'),
);

// Different format needed for matching cli output
// ignore: leading_newlines_in_multiline_strings
expect(globalConfig.readAsStringSync(), '''
\n## [very_good]
Expand Down Expand Up @@ -486,6 +490,7 @@ void main() {
..install('very_good')
..install('not_good');

// Different format needed for matching cli output
// ignore: leading_newlines_in_multiline_strings
expect(bashProfile.readAsStringSync(), '''
\n## [Completion]
Expand Down
1 change: 1 addition & 0 deletions test/src/installer/script_configuration_entry_test.dart
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
// Not needed for test files
// ignore_for_file: prefer_const_constructors

import 'dart:io';
Expand Down
Loading